Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

adding redirects so that old website API links surfaced from searches #16288

Closed
wants to merge 6 commits into from

Conversation

sojiadeshina
Copy link
Contributor

… redirect to proper locations in new website

Description

(Brief description on what this PR is about)

This allows the links in the top results of web searches with queries like "mxnet *** api" redirect to the right location in the new website. working on redirects for search results with links that refer to a specific version as well.

… redirect to proper locations in new website
Redirect 301 /tutorials/index.html /api
Redirect 301 /architecture/index.html /api/architecture/overview
Redirect 301 /community/ecosystem.html /ecosystem
Redirect 301 community/powered_by.html /ecosystem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a slash

Copy link
Contributor

@vishaalkapoor vishaalkapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/mod missing slash, 👍

@ThomasDelteil
Copy link
Contributor

@aaronmarkham @marcoabreu, please merge asap if CI passes 👍 this will be very helpful to our users, and if not, please give the CI a little nudge, thanks!

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasDelteil
Copy link
Contributor

ThomasDelteil commented Sep 27, 2019

@aaronmarkham beta doesn't work with current htaccess prod config either, I think it's a bug of beta env, it works on dev http://54.211.76.74/tutorials/index.html

@aaronmarkham aaronmarkham dismissed their stale review September 27, 2019 23:12

the problem was the staging server, not this PR

@aaronmarkham aaronmarkham changed the title adding redirects so that old website API links surfaced from searches… adding redirects so that old website API links surfaced from searches Sep 27, 2019
@aaronmarkham
Copy link
Contributor

@sad- I thought changing the name of the PR would trigger CI - it has in the past. Anyways, when #16304 gets merged, please rebase this PR, so it'll pass CI.

… redirect to proper locations in new website
@ThomasDelteil
Copy link
Contributor

closing and reopening under my own fork because current hypothesis is that "sad-" breaks the CI somewhere in bash

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants