Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] add numpy op bitwise_xor, hsplit, moveaxis, rot90 #16257

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

gyshi
Copy link
Contributor

@gyshi gyshi commented Sep 24, 2019

add numpy op bitwise_xor

fix some format problems

add numpy op moveaxis

fix code style

add numpy op rot90

fix pylint error

updata rot90

address comments

add numpy op hsplit

refactor split compute function

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@gyshi gyshi requested a review from szha as a code owner September 24, 2019 01:18
@gyshi
Copy link
Contributor Author

gyshi commented Sep 24, 2019

@reminisce , @haojin2 , thx for reviewing

src/operator/numpy/np_matrix_op.cc Outdated Show resolved Hide resolved
@sxjscience
Copy link
Member

LGTM in general, for implementing the forward op based on the forward/backward of another op, you may refer to the PR in #12821

@gyshi gyshi force-pushed the add_four_op branch 4 times, most recently from 8ce4075 to d36f54c Compare October 4, 2019 08:02
@gyshi
Copy link
Contributor Author

gyshi commented Oct 4, 2019

@sxjscience i refactor this code

add numpy op bitwise_xor

fix some format problems

add numpy op moveaxis

fix code style

add numpy op rot90

fix pylint error

updata rot90

address comments

add  numpy op hsplit

refactor split compute function

refactor moveaxis code
@reminisce reminisce merged commit 9681197 into apache:master Oct 15, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
add numpy op bitwise_xor

fix some format problems

add numpy op moveaxis

fix code style

add numpy op rot90

fix pylint error

updata rot90

address comments

add  numpy op hsplit

refactor split compute function

refactor moveaxis code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants