Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Random.choice implemented #16089

Merged
merged 10 commits into from
Sep 9, 2019
Merged

Conversation

xidulu
Copy link
Contributor

@xidulu xidulu commented Sep 4, 2019

Description

As title
https://docs.scipy.org/doc/numpy-1.16.1/reference/generated/numpy.random.choice.html

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Uniform/Weighted sampling with/without replacement implemented.
  • Allow input to be array/symbol.

Comments

@xidulu xidulu requested a review from szha as a code owner September 4, 2019 07:15
@haojin2 haojin2 changed the title [Numpy] Rancom.choice implemented [Numpy] Random.choice implemented Sep 6, 2019
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit e260f13 into apache:master Sep 9, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* imperative choice done

* unit test done

* expose take to np internal

* style fixed

* style fixed

* style problems fixed

* remove out parameter and fix style

* fix syntax error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants