Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update instructions for Clojure bindings #16084

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Update instructions for Clojure bindings #16084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contrib/clojure-package/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ After making this change and running `lein deps`, you should be able to run exam

### Option 2: Clojure package from Source, Scala Package from Jar

With this option, you will install a Git revision of the Clojure package source and a [Scala package jar from Maven](https://search.maven.org/search?q=g:org.apache.mxnet) with native dependencies baked in.
With this option, you will install a Git revision of the Clojure package source and a [Scala package jar from Maven](https://search.maven.org/search?q=g:org.apache.mxnet) with native dependencies baked in. Pick this if you want to make changes to the Clojure bindings but don't want to build the shared library or the Scala package jar yourself.

- Install additional dependencies as described in [the corresponding section for Option 1](#installing-additional-dependencies),

Expand Down Expand Up @@ -172,7 +172,7 @@ In that case, however, breakage can happen at any point, for instance when the S

### Option 3: Everything from Source

With this option, you will compile the core MXNet C++ package and jars for both Scala and Clojure language bindings from source. If you intend to make changes to the code in any of the parts, or if you simply want the latest and greatest features, this choice is for you.
With this option, you will compile the core MXNet C++ package and jars for both Scala and Clojure language bindings from source. If you intend to make changes to the C++ or Scala code, or if you simply want the latest and greatest features, this choice is for you.

The first step is to recursively clone the MXNet repository and checkout the desired version, (example 1.4.1). You should use the latest [version](https://search.maven.org/search?q=clojure-mxnet)), and clone into the `~/mxnet` directory:

Expand Down Expand Up @@ -207,8 +207,8 @@ The outcome of this step will be a shared library `lib/libmxnet.so` that is used
```

#### Building the Clojure jar
- Enter the `contrib/clojure` directory and edit the `project.clj` file. Add the Scala jar that was just created and installed, e.g., `[org.apache.mxnet/mxnet-full_2.11-osx-x86_64-cpu "latest-version-SNAPSHOT"]`, to the `:dependencies`.

- Enter the `contrib/clojure` directory.
- Run `lein test`. All the tests should run without an error.
- Run `lein install` to build and install the Clojure jar locally.

Expand Down
4 changes: 2 additions & 2 deletions contrib/clojure-package/project.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
;[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-cpu "<insert-snapshot-version>"]
;[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-gpu "<insert-snapshot-version"]

;;; CI
;;; CI / Local Build
[org.apache.mxnet/mxnet-full_2.11 "INTERNAL"]

[org.clojure/tools.logging "0.4.0"]
Expand All @@ -44,4 +44,4 @@
:repositories [["staging" {:url "https://repository.apache.org/content/repositories/staging" :snapshots true
:update :always}]
["snapshots" {:url "https://repository.apache.org/content/repositories/snapshots" :snapshots true
:update :always}]])
:update :always}]])