Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update instructions for Clojure bindings #16084

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

AlexChalk
Copy link
Contributor

@AlexChalk AlexChalk commented Sep 3, 2019

Description

While setting up the repository on my local machine, I came across some instructions that were out of date:

  • Building everything from source was recommended if you want to make changes to any of the code, but I understand from the mxnet Slack channel that using the nightly snapshots of the Scala package jar is adequate for making changes to the Clojure code.
  • Updating the project.clj file was part of the instructions for building everything from source, but this is no longer necessary.
  • Similarly the project.clj file lists [org.apache.mxnet/mxnet-full_2.11 "INTERNAL"] as used for CI builds, when it is also used for local builds of the Scala package jar.

This PR updates those instructions.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Update the Clojure package's README.md.
  • Update a comment in the Clojure package's project.clj.

@gigasquid
Copy link
Member

Thanks for your contribution to make the documentation better @adc17 😸

@gigasquid gigasquid merged commit 4333a7b into apache:master Sep 4, 2019
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants