This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Numpy] Numpy compatible bitwise_and operator #16009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review] |
5 tasks
haojin2
requested review from
haojin2 and
reminisce
and removed request for
szha
sxjscience
reviewed
Sep 12, 2019
sxjscience
reviewed
Sep 15, 2019
| test_bitwise_and.hybridize() | ||
|
|
||
| x1 = rand_ndarray(x1_shape, dtype=_np.dtype(int)).as_np_ndarray() | ||
| x2 = rand_ndarray(x2_shape, dtype=_np.dtype(int)).as_np_ndarray() |
There was a problem hiding this comment.
Should we test for all the supported dtypes, I think we support uint8, int8, int32, int64.
hgt312
reviewed
Sep 19, 2019
| // Special case of ElemwiseType. Constrains dtype to integer types | ||
| template<index_t n_in, index_t n_out> | ||
| inline bool ElemwiseIntType(const nnvm::NodeAttrs& attrs, | ||
| std::vector<int> *in_attrs, |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Numpy element-wise operator bitwise_and added.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
ElemwiseIntTypethat can be used to constrain dtypes to ints.Comments