This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy bitwise_and operation added #15306

Closed

zoeygxy wants to merge 14 commits into apache:numpy from zoeygxy:numpy_bitwise_and

Contributor

zoeygxy commented Jun 21, 2019 •

edited

Loading

Description

Numpy element-wise operator bitwise_and added

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Code is well-documented
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Added numpy element-wise operator: bitwise_and

Comments

haojin2 requested review from haojin2 and reminisce

June 21, 2019 07:27

haojin2 self-assigned this

haojin2 added the Numpy label

haojin2 reviewed

View reviewed changes

src/operator/numpy/np_elemwise_binary_op.cc Outdated Show resolved Hide resolved

haojin2 reviewed

View reviewed changes

src/operator/numpy/np_elemwise_binary_op.cc Show resolved Hide resolved

haojin2 reviewed

View reviewed changes

src/operator/numpy/np_elemwise_binary_op.cu Show resolved Hide resolved

haojin2 reviewed

View reviewed changes

tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved

haojin2 reviewed

View reviewed changes

tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved

haojin2 reviewed

View reviewed changes

tests/python/unittest/test_numpy_op.py Show resolved Hide resolved

wkcn reviewed

View reviewed changes

src/operator/mshadow_op.h Outdated Show resolved Hide resolved

src/operator/numpy/np_elemwise_binary_op.cc Show resolved Hide resolved

haojin2 reviewed

View reviewed changes

tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved

haojin2 approved these changes

View reviewed changes

Contributor

haojin2 left a comment

LGTM. Will merge once CI passes.

Roshrini added the pr-awaiting-review label

zoeygxy added 14 commits

July 3, 2019 10:39


          Implemented, before refactoring with new template

c4fac92


          Refactored with new template

372992f


          Test file added

1b203a4


          Dependency fix

b0720a4


          Dependency fix +1

650d0bb


          Dependency fix +1

c702afd


          Test added; for GPU test

903ee31


          Broadcast adaption added; cpu & gpu tests passed; linted

0aa9e67


          git conflict resovled

b7f845c


          Style fixed

f53442f


          style fixed - redundant comment removed, bitwise_and

a7f4385


          bitwise_and style fixed according to code review

57d3e68


          Removed unnecessary 'add_grad' in test file

494b17a


          Rebased; added typecast for output

e90913b

zoeygxy force-pushed the numpy_bitwise_and branch from 998ed90 to e90913b Compare

July 3, 2019 03:29

zoeygxy requested a review from szha as a code owner

July 3, 2019 03:29

Contributor Author

zoeygxy commented Jul 3, 2019

Waiting for GCD PR's INT_TYPE_SWITCH to merge. Will use it to restrict the input dtype.

zoeygxy closed this

Contributor Author

zoeygxy commented Aug 26, 2019

This operator will be directly moved to the master branch. See #16009.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Numpy pr-awaiting-review