This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Disable test coverage of C++ codebase on CI #15981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu1130
force-pushed
the
disable_test_coverage_ci
branch
from
August 23, 2019 01:21
a087707
to
0c1a4e5
Compare
marcoabreu
approved these changes
Aug 23, 2019
stu1130
force-pushed
the
disable_test_coverage_ci
branch
from
August 23, 2019 17:25
0c1a4e5
to
f66caee
Compare
@mxnet-label-bot add [pr-awaiting-review] |
@anirudhacharya I already approved |
@stu1130 It seems centos-gpu failed to build. I have re-triggered it for multiple times. Could you please take a look? |
@yuxihu Sure |
@marcoabreu apologies, did not see your review. |
stu1130
force-pushed
the
disable_test_coverage_ci
branch
from
August 29, 2019 23:21
1628d90
to
47e03d6
Compare
stu1130
force-pushed
the
disable_test_coverage_ci
branch
from
August 30, 2019 01:01
47e03d6
to
646e0ba
Compare
anirudh2290
reviewed
Aug 30, 2019
stu1130
force-pushed
the
disable_test_coverage_ci
branch
from
August 30, 2019 01:27
0a0a31e
to
a881715
Compare
zixuanweeei
pushed a commit
to zixuanweeei/mxnet
that referenced
this pull request
Sep 2, 2019
* disable test coverage on ci * address the comment * retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pr-awaiting-merge
Review and CI is complete. Ready to Merge
pr-awaiting-review
PR is waiting for code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #15971
Root Cause
When linker link the object files, it uses relative addressing method. The error happens when the project is too large for linker to link the target objects using relative addressing with 32-bit address.
Things we have tried
After discussion with @marcoabreu, we agreed to disable C++ backend test coverage monitoring, which will also boost the CI.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@marcoabreu could you help check if some runtime functions are missing or some functions should not disable? Thanks