address the comment

apache · Aug 30, 2019 · 0a0a31e · 0a0a31e
1 parent 646e0ba
commit 0a0a31e
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/include/mxnet/tuple.h b/include/mxnet/tuple.h
@@ -200,10 +200,10 @@ class Tuple {
    */
   inline ValueType& operator[](int i) {
     // it fixes the false alarm of assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Werror=strict-overflow]
-    #pragma GCC diagnostic push
-    #pragma GCC diagnostic ignored "-Wstrict-overflow"
-      CHECK(i >= 0 && i < ndim()) << "index = " << i << " must be in range [0, " << ndim() << ")";
-    #pragma GCC diagnostic pop
+  #pragma GCC diagnostic push
+  #pragma GCC diagnostic ignored "-Wstrict-overflow"
+    CHECK(i >= 0 && i < ndim()) << "index = " << i << " must be in range [0, " << ndim() << ")";
+  #pragma GCC diagnostic pop
     return begin()[i];
   }
   /*!
@@ -212,7 +212,11 @@ class Tuple {
    * \return the corresponding dimension size
    */
   inline const ValueType& operator[](int i) const {
+    // it fixes the false alarm of assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Werror=strict-overflow]
+  #pragma GCC diagnostic push
+  #pragma GCC diagnostic ignored "-Wstrict-overflow"
     CHECK(i >= 0 && i < ndim()) << "index = " << i << " must be in range [0, " << ndim() << ")";
+  #pragma GCC diagnostic pop
     return begin()[i];
   }
   /*!