Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.5.x] prevent TRT_Logger to be destroyed before TRT engine (#14898) #15877

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

KellenSunderland
Copy link
Contributor

Description

prevent TRT_Logger to be destroyed before TRT engine

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:

Changes

  • add TRT_Logger in TRTEngineParam
  • delete TRT_Logger when TRTEngineParam

Comments

  • Correct a bug that is exposed when using CUDA 10.1

* prevent TRT_Logger to be destroyed before TRT engine

* use unique_ptr for trt_logger/parser/engine/executor ownership

* reduce line length for lint
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoLv TaoLv merged commit bd2b5a2 into apache:v1.5.x Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants