This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Numpy add numpy op hanning, hamming, blackman #15815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyshi
force-pushed
the
hanning
branch
2 times, most recently
from
9ecd328
to
14fc78f
Compare
haojin2
reviewed
Aug 15, 2019
gyshi
changed the title
gyshi
force-pushed
the
hanning
branch
4 times, most recently
from
6cd146e
to
bea9be8
Compare
comaniac
suggested changes
Sep 11, 2019
python/mxnet/ndarray/numpy/_op.py
Outdated
|
|
||
|
|
||
| @set_module('mxnet.ndarray.numpy') | ||
| def hanning(M, dtype=_np.float64, ctx=None): |
comaniac
suggested changes
Sep 14, 2019
python/mxnet/ndarray/numpy/_op.py
Outdated
|
|
||
|
|
||
| @set_module('mxnet.ndarray.numpy') | ||
| def hanning(M, dtype=None, ctx=None): |
There was a problem hiding this comment.
I still prefer to use float64 as the default type in the function argument instead of having a checker at the beginning of the function. The reason is that the type of dtype would be Union[None, str, numpy.dtype] in the current implementation, which is inconsistent with the docstring saying that dtype : str or numpy.dtype. Also, it makes the semantic ambiguous and should be avoided especially in Python 3.7. If the default value of dtype in the argument is np.float64 or 'float64' then we can enforce its type to be Union[str, numpy.dtype] as documented.
There was a problem hiding this comment.
it's good, i think i should use float32 as the defaulet type,
gyshi
force-pushed
the
hanning
branch
2 times, most recently
from
c1ac152
to
d5754e4
Compare
comaniac
approved these changes
Sep 15, 2019
address test file fix test file make default dtype is float32
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
address test file fix test file make default dtype is float32
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
address test file fix test file make default dtype is float32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments