This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Large tensor support for random ops #15783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeforest
reviewed
Aug 9, 2019
|
addressed! |
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* random ops * replace array with uniform * remove dtype * randn add * add multinomial * multi,randn small fix * add negative bino * fix memory issue - Failed to allocate CPU Memory * Trigger notification * linting fix * Trigger notification
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* random ops * replace array with uniform * remove dtype * randn add * add multinomial * multi,randn small fix * add negative bino * fix memory issue - Failed to allocate CPU Memory * Trigger notification * linting fix * Trigger notification
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* random ops * replace array with uniform * remove dtype * randn add * add multinomial * multi,randn small fix * add negative bino * fix memory issue - Failed to allocate CPU Memory * Trigger notification * linting fix * Trigger notification
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* random ops * replace array with uniform * remove dtype * randn add * add multinomial * multi,randn small fix * add negative bino * fix memory issue - Failed to allocate CPU Memory * Trigger notification * linting fix * Trigger notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support int64 (large tensor) for remaining random ops
Below 8 are supported
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Added 1 test case each
Comments
Currently
nosetests tests/nightly/test_large_array.pyresults in 42 tests pass(4 fail - unrelated test ops-
topk,sort,argsort,reduce)