-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add symbol api for randn and fix shape issue for randn ndarray and symbol api #15772
Conversation
@mxnet-label-bot add [Bug, Operator, Doc] |
Are you sure that its for Symbolic as well ? If thats not a restriction shouldn't we add unittest for symbolic mode too ? |
Addressed comment. Verified unit-tests work with
For these build flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add unit tests as @kshitij12345 suggested.
LGTM |
@ChaiBapchya gentle ping to trigger CI so we can merge. thanks! |
@apeforest @kshitij12345 addressed! Pl review. Thank you! |
@kshitij12345 @apeforest @roywei ready for review. |
Description
Randn is not currently present in symbol API
Fixes Absence of randn function in Symbol API #12755
Currently randn gives issue when passed NDArray to the randn function parameters loc and scale
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Original works as well
loc and scale scalar
loc and scale as NDArray