This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[OpPerf] Take care of 4d param #15736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot Add [Performance, pr-awaiting-review] |
apeforest
reviewed
Aug 13, 2019
larroy
approved these changes
Aug 14, 2019
apeforest
approved these changes
Aug 19, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* take care of 4d * Trigger notification * Trigger notification * Trigger notification * Trigger notification * Trigger notification * Trigger notification * Trigger notification * Trigger notification * Trigger notification bcoz validation/edge passed but shows pending
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PR #15606 introduced a bug (if condition resulted in ALWAYS using 4D tensor instead of just using it specific to 2 ops)
Results
Both old and updated results
Old buggy implementation found (1,4,2,4) - 77 times
New updated found it 2 times (
space_to_depthanddepth_to_space)https://gist.github.com/ChaiBapchya/b3c4d14d039daa9e72cafd92fcc3255f
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Changed the function signature to take operator as a parameter.
Now I can verify if that operator is an op that needs 4D tensor specifically and only then pass 4D data.
Comments
Missed this because when I run benchmark tests they run without failure.
Just that input is 4d instead of default 2d tensors (of larger size)