-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Opperf] Add array rearrange operators to opperf #15606
[Opperf] Add array rearrange operators to opperf #15606
Conversation
657d410
to
f4fd932
Compare
@mxnet-label-bot add [Operator, Performance, pr-awaiting-review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
Please add results seen on CPU/GPU for reference.
Did you run opperf for all operators after this change?
6bf8c2e
to
f20ae8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the results, I don't see avg forward time for "flip" and "swapaxes" ?
Ya right. Moreover, functions like |
Also, found that All these operators are aliases and are untracked or wrongly parsed from the profiler output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
LGTM.
Created a feature request to track enhancements we need to make to MXNet operator registry APIs -
#15654
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add array rearrange operators to opperf * Trigger notification * 4d tensor, param support * new line * add alias logic
Description
Added Rearray operators to the existing set of opperf benchmarks
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Results
GPU - https://gist.github.com/ChaiBapchya/51b6c7c2346959f3f72aa1b702eb002d
CPU - https://gist.github.com/ChaiBapchya/37b27d4803e73e0fa5a8bd6e8da11492
Comments
@sandeep-krishnamurthy @apeforest