This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
got the following failures:
|
Also getting some random failures in the CI:
|
junrushao
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-)
Probably the CI flakiness can be reported in separate issue? |
szha
suggested changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like group norm PR was mixed in this PR.
@mxnet-label-bot add [Build, pr-awaiting-response] |
marcoabreu
added
Build
pr-awaiting-response
PR is reviewed and waiting for contributor to respond
labels
Jul 19, 2019
This was referenced Jul 19, 2019
@szha removed the incorrect merge |
Should be good to merge @szha |
@mxnet-label-bot add [pr-awaiting-merge] |
@mxnet-label-bot remove [pr-awaiting-response] |
marcoabreu
removed
the
pr-awaiting-response
PR is reviewed and waiting for contributor to respond
label
Jul 20, 2019
szha
approved these changes
Jul 20, 2019
TaoLv
pushed a commit
to TaoLv/incubator-mxnet
that referenced
this pull request
Aug 9, 2019
7 tasks
TaoLv
added a commit
that referenced
this pull request
Aug 11, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in TShape upgrades for constructor in warpctc
Checklist
Essentials
Fixes #15612
@junrushao1994