Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

WarpCTC build failure in 1.5.0 #15612

Closed
samskalicky opened this issue Jul 19, 2019 · 2 comments · Fixed by #15601
Closed

WarpCTC build failure in 1.5.0 #15612

samskalicky opened this issue Jul 19, 2019 · 2 comments · Fixed by #15601

Comments

@samskalicky
Copy link
Contributor

Building the warpCTC plugin fails i 1.5.0 due to this PR #14270

It fails with the following error:

In file included from plugin/warpctc/warpctc.cc:27:0:
plugin/warpctc/./warpctc-inl.h: In member function ‘virtual bool mxnet::op::WarpCTCProp::InferShape(mxnet::ShapeVector*, mxnet::ShapeVector*, mxnet::ShapeVector*) const’:
plugin/warpctc/./warpctc-inl.h:257:48: error: no matching function for call to ‘mxnet::TShape::TShape(int)’
     mxnet::TShape label_shape(dshape.ndim() - 1);
                                                ^
plugin/warpctc/./warpctc-inl.h:257:48: note: candidates are:
In file included from include/mxnet/./base.h:38:0,
                 from include/mxnet/operator.h:38,
                 from plugin/warpctc/./warpctc-inl.h:31,
                 from plugin/warpctc/warpctc.cc:27:
include/mxnet/./tuple.h:519:10: note: template<int dim> mxnet::TShape::TShape(mshadow::Shape<ndim>&&)
   inline TShape(mshadow::Shape<dim> &&s) {// NOLINT(*)
          ^
include/mxnet/./tuple.h:519:10: note:   template argument deduction/substitution failed:
In file included from plugin/warpctc/warpctc.cc:27:0:
plugin/warpctc/./warpctc-inl.h:257:48: note:   mismatched types ‘mshadow::Shape<ndim>’ and ‘int’
     mxnet::TShape label_shape(dshape.ndim() - 1);
                                                ^

looks like nnvm::Tshape takes a single int for constructor:
https://github.com/dmlc/tvm/blob/master/nnvm/include/nnvm/tuple.h#L352

But mxnet::Tshape does not have this constructor, instead we provide the default value as well (which is value: 1 in nnvm)
https://github.com/apache/incubator-mxnet/blob/master/include/mxnet/tuple.h#L406

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Build

@vrakesh
Copy link
Contributor

vrakesh commented Jul 19, 2019

@samskalicky Thanks for reporting this Sam, and thanks for the quick PR as well

@mxnet-label-bot add [Build, Bug]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants