Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Make Clojure API Generator Tests Less Brittle #15579

Merged

Conversation

gigasquid
Copy link
Member

Description

Address #15571

This makes the api generator tests less brittle. The generated apis contain documentation with the source line numbers from the c code. The tests broke whenever the underlying code changed.
This PR makes it so it just compares the generated function name and not the full generated code.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@gigasquid gigasquid changed the title make Clojure api generator tests less brittle make Clojure API generator tests less brittle Jul 17, 2019
@gigasquid gigasquid changed the title make Clojure API generator tests less brittle Make Clojure API Generator Tests Less Brittle Jul 18, 2019
@reminisce
Copy link
Contributor

Thanks for acting promptly. :)

@reminisce reminisce merged commit 9983adb into apache:master Jul 18, 2019
@kedarbellare
Copy link
Contributor

@gigasquid thanks for the fix!!

@gigasquid gigasquid deleted the make-clojure-generator-tests-less-brittle branch August 14, 2019 20:08
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants