make clojure api generator tests less brittle (#15579)

apache · Jul 18, 2019 · 9983adb · 9983adb
1 parent 35b5480
commit 9983adb
Showing 1 changed file with 24 additions and 17 deletions.
diff --git a/contrib/clojure-package/test/dev/generator_test.clj b/contrib/clojure-package/test/dev/generator_test.clj
@@ -17,7 +17,14 @@
 
 (ns dev.generator-test
   (:require [clojure.test :refer :all]
-            [dev.generator :as gen]))
+            [dev.generator :as gen]
+            [clojure.string :as string]))
+
+(defn file-function-name [f]
+  (->> (string/split (slurp f) #"\n")
+       (take 33)
+       last
+       (string/trim)))
 
 (deftest test-clojure-case
   (is (= "foo-bar" (gen/clojure-case "FooBar")))
@@ -334,20 +341,20 @@
           fns (gen/all-symbol-api-functions gen/op-names)
           _ (gen/write-to-file [(first fns) (second fns)]
                                (gen/symbol-api-gen-ns false)
-                               fname)
-          good-contents (slurp "test/good-test-symbol-api.clj")
-          contents (slurp fname)]
-      (is (= good-contents contents))))
+                               fname)]
+      (is (= "activation"
+             (file-function-name "test/good-test-symbol-api.clj")
+             (file-function-name fname)))))
 
   (testing "symbol-random-api"
     (let [fname "test/test-symbol-random-api.clj"
           fns (gen/all-symbol-random-api-functions gen/op-names)
           _ (gen/write-to-file [(first fns) (second fns)]
                                (gen/symbol-api-gen-ns true)
-                               fname)
-          good-contents (slurp "test/good-test-symbol-random-api.clj")
-          contents (slurp fname)]
-      (is (= good-contents contents))))
+                               fname)]
+      (is (= "exponential"
+             (file-function-name "test/good-test-symbol-random-api.clj")
+             (file-function-name fname)))))
 
 
  (testing "symbol"
@@ -364,20 +371,20 @@
           fns (gen/all-ndarray-api-functions gen/op-names)
           _ (gen/write-to-file [(first fns) (second fns)]
                                (gen/ndarray-api-gen-ns false)
-                               fname)
-          good-contents (slurp "test/good-test-ndarray-api.clj")
-          contents (slurp fname)]
-      (is (= good-contents contents))))
+                               fname)]
+      (is (= "activation"
+             (file-function-name "test/good-test-ndarray-api.clj")
+             (file-function-name fname)))))
 
   (testing "ndarray-random-api"
     (let [fname "test/test-ndarray-random-api.clj"
           fns (gen/all-ndarray-random-api-functions gen/op-names)
           _ (gen/write-to-file [(first fns) (second fns)]
                                (gen/ndarray-api-gen-ns true)
-                               fname)
-          good-contents (slurp "test/good-test-ndarray-random-api.clj")
-          contents (slurp fname)]
-      (is (= good-contents contents))))
+                               fname)]
+      (is (= "exponential"
+             (file-function-name "test/good-test-ndarray-random-api.clj")
+             (file-function-name fname)))))
 
   (testing "ndarray"
     (let [fname "test/test-ndarray.clj"