Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

FP16 Support for C Predict API #15245

Merged
merged 23 commits into from
Jul 13, 2019
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
40beeb2
Upgrade archive utility and add back FC improvement
anirudh2290 Jun 6, 2019
928055f
Change permissions for Ubuntu AR
anirudh2290 Jun 7, 2019
2b418d3
Extract and cd into binutils dir
anirudh2290 Jun 7, 2019
b823623
Allow AR path to be chosen by user
anirudh2290 Jun 7, 2019
d89ce85
Add AR path to build
anirudh2290 Jun 7, 2019
f28bcfa
Fix AR paths
anirudh2290 Jun 7, 2019
7c0e25b
Revert AR flag in makefile
anirudh2290 Jun 7, 2019
849c513
Build from source doc updated
anirudh2290 Jun 7, 2019
9850ea4
Commit for C Predict API
anirudh2290 Jun 12, 2019
41f5c86
Add FP16 predict support
anirudh2290 Jun 14, 2019
19b802e
Ubuntu AR fix
anirudh2290 Jun 20, 2019
14ff1f7
Add Test Predictor fixes
anirudh2290 Jun 20, 2019
9985dec
Add test for predictor
anirudh2290 Jun 20, 2019
75ae0da
Merge branch 'master' of https://github.com/apache/incubator-mxnet in…
anirudh2290 Jun 20, 2019
ac9c81c
Cleanup fixes
anirudh2290 Jun 20, 2019
15964be
Fixes
anirudh2290 Jun 28, 2019
f7a9058
Add support for forward pass only for gpu
anirudh2290 Jun 28, 2019
d6f0cea
Fix Reshape, move test to gpu
anirudh2290 Jun 29, 2019
574537f
Merge branch 'master' of https://github.com/apache/incubator-mxnet in…
anirudh2290 Jul 2, 2019
a14d2c7
Add monitor callback for C Predict API
anirudh2290 Jul 5, 2019
84d8652
Add tests, default dtype and set_monitor_callback
anirudh2290 Jul 5, 2019
577deb9
Improve error
anirudh2290 Jul 5, 2019
d911bfa
Fix c_str_array
anirudh2290 Jul 8, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 107 additions & 5 deletions amalgamation/python/mxnet_predict.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,74 @@

import os
import sys
from array import array
import ctypes
import logging
import numpy as np

# pylint: disable= no-member
_DTYPE_NP_TO_MX = {
None: -1,
sandeep-krishnamurthy marked this conversation as resolved.
Show resolved Hide resolved
np.float32: 0,
np.float64: 1,
np.float16: 2,
np.uint8: 3,
np.int32: 4,
np.int8: 5,
np.int64: 6,
}

_DTYPE_MX_TO_NP = {
-1: None,
0: np.float32,
1: np.float64,
2: np.float16,
3: np.uint8,
4: np.int32,
5: np.int8,
6: np.int64,
}

__all__ = ["Predictor", "load_ndarray_file"]

if sys.version_info[0] == 3:
py_str = lambda x: x.decode('utf-8')

def c_str_array(strings):
"""Create ctypes const char ** from a list of Python strings.

Parameters
----------
strings : list of strings
Python strings.

Returns
-------
(ctypes.c_char_p * len(strings))
A const char ** pointer that can be passed to C API.
"""
arr = (ctypes.c_char_p * len(strings))()
arr[:] = strings
return arr
else:
py_str = lambda x: x

def c_str_array(strings):
"""Create ctypes const char ** from a list of Python strings.

Parameters
----------
strings : list of string
Python strings.

Returns
-------
(ctypes.c_char_p * len(strings))
A const char ** pointer that can be passed to C API.
"""
arr = (ctypes.c_char_p * len(strings))()
arr[:] = [s.encode('utf-8') for s in strings]
return arr

def c_str(string):
""""Convert a python string to C string."""
Expand All @@ -48,6 +105,11 @@ def c_array(ctype, values):
"""Create ctypes array from a python array."""
return (ctype * len(values))(*values)

def c_array_buf(ctype, buf):
"""Create ctypes array from a Python buffer."""
return (ctype * len(buf)).from_buffer(buf)



def _find_lib_path():
"""Find mxnet library."""
Expand Down Expand Up @@ -90,6 +152,7 @@ def _check_call(ret):
_LIB = _load_lib()
# type definitions
mx_uint = ctypes.c_uint
mx_int = ctypes.c_int
mx_float = ctypes.c_float
mx_float_p = ctypes.POINTER(mx_float)
PredictorHandle = ctypes.c_void_p
Expand All @@ -116,10 +179,13 @@ class Predictor(object):

dev_id : int, optional
The device id of the predictor.

type_dict : Dict of str->numpy.dtype
Input type dictionary, name->dtype
"""
def __init__(self, symbol_file,
param_raw_bytes, input_shapes,
dev_type="cpu", dev_id=0):
dev_type="cpu", dev_id=0, type_dict=None):
dev_type = devstr2type[dev_type]
indptr = [0]
sdata = []
Expand All @@ -133,15 +199,38 @@ def __init__(self, symbol_file,
handle = PredictorHandle()
param_raw_bytes = bytearray(param_raw_bytes)
ptr = (ctypes.c_char * len(param_raw_bytes)).from_buffer(param_raw_bytes)
_check_call(_LIB.MXPredCreate(

# data types
num_provided_arg_types = 0
# provided type argument names
provided_arg_type_names = ctypes.POINTER(ctypes.c_char_p)()
# provided types
provided_arg_type_data = ctypes.POINTER(mx_uint)()
if type_dict is not None:
provided_arg_type_names = []
provided_arg_type_data = []
for k, v in type_dict.items():
v = np.dtype(v).type
if v in _DTYPE_NP_TO_MX:
provided_arg_type_names.append(k)
anirudh2290 marked this conversation as resolved.
Show resolved Hide resolved
provided_arg_type_data.append(_DTYPE_NP_TO_MX[v])
num_provided_arg_types = mx_uint(len(provided_arg_type_names))
provided_arg_type_names = c_str_array(provided_arg_type_names)
provided_arg_type_data = c_array_buf(ctypes.c_int, array('i', provided_arg_type_data))

_check_call(_LIB.MXPredCreateEx(
c_str(symbol_file),
ptr, len(param_raw_bytes),
ctypes.c_int(dev_type), ctypes.c_int(dev_id),
mx_uint(len(indptr) - 1),
c_array(ctypes.c_char_p, keys),
c_array(mx_uint, indptr),
c_array(mx_uint, sdata),
num_provided_arg_types,
provided_arg_type_names,
provided_arg_type_data,
ctypes.byref(handle)))
self.type_dict = type_dict
self.handle = handle

def __del__(self):
Expand All @@ -160,10 +249,18 @@ def forward(self, **kwargs):
>>> predictor.forward(data=mydata)
>>> out = predictor.get_output(0)
"""
if self.type_dict and len(self.type_dict) != len(kwargs.items()):
raise ValueError("number of kwargs should be same as len of type_dict" \
"Please check your forward pass inputs" \
"or type_dict passed to Predictor instantiation")

for k, v in kwargs.items():
if not isinstance(v, np.ndarray):
raise ValueError("Expect numpy ndarray as input")
v = np.asarray(v, dtype=np.float32, order='C')
if self.type_dict and k in self.type_dict:
v = np.asarray(v, dtype=self.type_dict[k], order='C')
sandeep-krishnamurthy marked this conversation as resolved.
Show resolved Hide resolved
else:
v = np.asarray(v, dtype=np.float32, order='C')
sandeep-krishnamurthy marked this conversation as resolved.
Show resolved Hide resolved
anirudh2290 marked this conversation as resolved.
Show resolved Hide resolved
_check_call(_LIB.MXPredSetInput(
self.handle, c_str(k),
v.ctypes.data_as(mx_float_p),
Expand Down Expand Up @@ -218,12 +315,16 @@ def get_output(self, index):
"""
pdata = ctypes.POINTER(mx_uint)()
ndim = mx_uint()
out_type = mx_int()
_check_call(_LIB.MXPredGetOutputShape(
self.handle, index,
ctypes.byref(pdata),
ctypes.byref(ndim)))
_check_call(_LIB.MXPredGetOutputType(
self.handle, index,
ctypes.byref(out_type)))
shape = tuple(pdata[:ndim.value])
data = np.empty(shape, dtype=np.float32)
data = np.empty(shape, dtype=_DTYPE_MX_TO_NP[out_type.value])
_check_call(_LIB.MXPredGetOutput(
self.handle, mx_uint(index),
data.ctypes.data_as(mx_float_p),
Expand Down Expand Up @@ -273,4 +374,5 @@ def load_ndarray_file(nd_bytes):
if len(keys) == 0 or len(keys[0]) == 0:
return arrs
else:
return {keys[i] : arrs[i] for i in range(len(keys))}
return {keys[i] : arrs[i] for i in range(len(keys))
}
50 changes: 50 additions & 0 deletions include/mxnet/c_predict_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,44 @@ MXNET_DLL int MXPredCreate(const char* symbol_json_str,
const mx_uint* input_shape_data,
PredictorHandle* out);

/*!
* \brief create a predictor
* \param symbol_json_str The JSON string of the symbol.
* \param param_bytes The in-memory raw bytes of parameter ndarray file.
* \param param_size The size of parameter ndarray file.
* \param dev_type The device type, 1: cpu, 2: gpu
* \param dev_id The device id of the predictor.
* \param num_input_nodes Number of input nodes to the net.
* For feedforward net, this is 1.
* \param input_keys The name of the input argument.
* For feedforward net, this is {"data"}
* \param input_shape_indptr Index pointer of shapes of each input node.
* The length of this array = num_input_nodes + 1.
* For feedforward net that takes 4 dimensional input, this is {0, 4}.
* \param input_shape_data A flattened data of shapes of each input node.
* For feedforward net that takes 4 dimensional input, this is the shape data.
* \param num_provided_arg_dtypes
* The length of provided_arg_dtypes.
* \param provided_arg_dtype_names
* The provided_arg_dtype_names the names of args for which dtypes are provided.
* \param provided_arg_dtypes
* The provided_arg_dtypes the dtype provided
* \param out The created predictor handle.
* \return 0 when success, -1 when failure.
*/
MXNET_DLL int MXPredCreateEx(const char* symbol_json_str,
const void* param_bytes,
int param_size,
int dev_type, int dev_id,
mx_uint num_input_nodes,
anirudh2290 marked this conversation as resolved.
Show resolved Hide resolved
const char** input_keys,
const mx_uint* input_shape_indptr,
const mx_uint* input_shape_data,
const mx_uint num_provided_arg_dtypes,
const char** provided_arg_dtype_names,
const int* provided_arg_dtypes,
PredictorHandle* out);

/*!
* \brief create a predictor wich customized outputs
* \param symbol_json_str The JSON string of the symbol.
Expand Down Expand Up @@ -186,6 +224,18 @@ MXNET_DLL int MXPredGetOutputShape(PredictorHandle handle,
mx_uint index,
mx_uint** shape_data,
mx_uint* shape_ndim);

/*!
* \brief Get the dtype of output node.
* The returned data type is only valid before next call to MXPred function.
* \param handle The handle of the predictor.
* \param out_index The index of the output node, set to 0 if there is only one output.
* \param out_dtype The dtype of the output node
*/
MXNET_DLL int MXPredGetOutputType(PredictorHandle handle,
mx_uint out_index,
int* out_dtype);

/*!
* \brief Set the input data of predictor.
* \param handle The predictor handle.
Expand Down
Loading