Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

FP16 Support for C Predict API #15245

Merged
merged 23 commits into from
Jul 13, 2019
Merged

FP16 Support for C Predict API #15245

merged 23 commits into from
Jul 13, 2019

Conversation

anirudh2290
Copy link
Member

Description

Adds dtype support for C Predict API.
Fixes: #14159 and #13335

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Jun 14, 2019
@anirudh2290 anirudh2290 marked this pull request as ready for review June 20, 2019 20:19
@anirudh2290 anirudh2290 changed the title [WIP] FP16 Support for C Predict API FP16 Support for C Predict API Jun 20, 2019
@anirudh2290 anirudh2290 changed the title FP16 Support for C Predict API [WIP] FP16 Support for C Predict API Jun 24, 2019
@anirudh2290 anirudh2290 changed the title [WIP] FP16 Support for C Predict API FP16 Support for C Predict API Jun 29, 2019
@sandeep-krishnamurthy sandeep-krishnamurthy removed the pr-work-in-progress PR is still work in progress label Jul 2, 2019
sandeep-krishnamurthy
sandeep-krishnamurthy previously requested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great work.
Few comments and questions.

amalgamation/python/mxnet_predict.py Show resolved Hide resolved
amalgamation/python/mxnet_predict.py Show resolved Hide resolved
amalgamation/python/mxnet_predict.py Show resolved Hide resolved
amalgamation/python/mxnet_predict.py Show resolved Hide resolved
amalgamation/python/mxnet_predict.py Show resolved Hide resolved
include/mxnet/c_predict_api.h Outdated Show resolved Hide resolved
src/c_api/c_predict_api.cc Outdated Show resolved Hide resolved
src/c_api/c_predict_api.cc Show resolved Hide resolved
src/c_api/c_predict_api.cc Outdated Show resolved Hide resolved
@sandeep-krishnamurthy sandeep-krishnamurthy dismissed their stale review July 3, 2019 22:51

Overall looks good to me. Waiting for test cases.

@simonmaurer
Copy link

thank you!

sandeep-krishnamurthy
sandeep-krishnamurthy approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

amalgamation/python/mxnet_predict.py Show resolved Hide resolved
@anirudh2290 anirudh2290 merged commit d677d1a into apache:master Jul 13, 2019
@anirudh2290 anirudh2290 mentioned this pull request Jul 13, 2019
Closed
@chengzhengxin chengzhengxin mentioned this pull request Aug 19, 2019
Closed
@samskalicky samskalicky mentioned this pull request Aug 21, 2019
Closed
samskalicky pushed a commit to samskalicky/incubator-mxnet that referenced this pull request Aug 28, 2019
@anirudh2290
FP16 Support for C Predict API (apache#15245)
a182b9f 
* Upgrade archive utility and add back FC improvement

This reverts commit 6543488.

* Change permissions for Ubuntu AR

* Extract and cd into binutils dir

* Allow AR path to be chosen by user

* Add AR path to build

* Fix AR paths

* Revert AR flag in makefile

* Build from source doc updated

* Commit for C Predict API

* Add FP16 predict support

* Add Test Predictor fixes

* Add test for predictor

* Cleanup fixes

* Fixes

* Add support for forward pass only for gpu

* Fix Reshape, move test to gpu

* Add monitor callback for C Predict API

* Add tests, default dtype and set_monitor_callback

* Improve error

* Fix c_str_array
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy approved these changes

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support fp16 for C Predict API
5 participants
@anirudh2290 @vandanavk @simonmaurer @sandeep-krishnamurthy @marcoabreu