Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Group Normalization #14959

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Group Normalization #14959

merged 3 commits into from
Jul 19, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented May 15, 2019

Description

Group Normalization

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Forward
  • Backward
  • Unit tests
  • Gluon block
  • Unit test for Gluon

Comments

Related:
#14196 #11283
Flakiness Checks:

MXNET_TEST_COUNT=10000 nosetests tests/python/unittest/test_operator.py:test_groupnorm
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=1680041162 to reproduce.
.
----------------------------------------------------------------------
Ran 1 test in 136.546s

OK
MXNET_TEST_COUNT=10000 nosetests tests/python/gpu/test_operator_gpu.py:test_groupnorm
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=2085401116 to reproduce.
.
----------------------------------------------------------------------
Ran 1 test in 172.874s

OK

@haojin2
Copy link
Contributor Author

haojin2 commented May 15, 2019

@junrushao1994 For review if you have time.

@szha
Copy link
Member

szha commented May 15, 2019

cc @sxjscience

@hetong007
Copy link
Contributor

@zhanghang1989 FYI

@haojin2 haojin2 force-pushed the groupnorm branch 2 times, most recently from 642dce3 to d1a215b Compare May 15, 2019 23:03
@haojin2 haojin2 changed the title [Don't Merge] [WIP] Group Normalization Group Normalization May 15, 2019
@zhreshold
Copy link
Member

@haojin2 can you check why unitest is failing?

@haojin2
Copy link
Contributor Author

haojin2 commented May 22, 2019

@zhreshold Looking into it...

@haojin2
Copy link
Contributor Author

haojin2 commented May 23, 2019

@zhreshold The failure is on fp16 data type, previously it could endure 10000 trials on my end and now it could not, I'm looking into the issue.

@haojin2 haojin2 force-pushed the groupnorm branch 4 times, most recently from 2b4b2ba to 794e919 Compare May 30, 2019 23:03
@haojin2 haojin2 force-pushed the groupnorm branch 2 times, most recently from f175858 to 622f7ce Compare June 4, 2019 18:54
@haojin2 haojin2 force-pushed the groupnorm branch 2 times, most recently from e91b389 to 6f52891 Compare June 21, 2019 03:00
@zhreshold
Copy link
Member

@haojin2 is CI still failing?

@Jerryzcn
Copy link
Contributor

Is there an issue related to CI failing?

@karan6181
Copy link
Contributor

@sxjscience @zhreshold Could you please review this PR again?

@haojin2 Could you please re-trigger the CI and look into failure ? Thanks

@haojin2
Copy link
Contributor Author

haojin2 commented Jul 19, 2019

@zhreshold @Jerryzcn @sxjscience @eric-haibin-lin CI passed, ready for merge

@haojin2 haojin2 requested a review from zhreshold July 19, 2019 04:32
@sxjscience
Copy link
Member

I'll merge first. Need to make a PR to revise the test_util + add test for grad_req=kAddTo. Let's make sure all OPs are tested for grad_req=kAddTo (Need to combine the efforts with DeepNumpy).

@sxjscience sxjscience merged commit eec0fb4 into apache:master Jul 19, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* GroupNorm

* add to amp list

* re-write forward
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants