Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Group Normalization #14196

Closed
wants to merge 4 commits into from
Closed

Group Normalization #14196

wants to merge 4 commits into from

Conversation

zhanghang1989
Copy link
Contributor

Description

Using the BN as the backend. Currently, the block is not hybridizable, due to reading batch size.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

szha
szha suggested changes Feb 18, 2019
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it’s not hybridizable, it probably shouldn’t be offered as HybridBlock. How about adding it in contrib for now?

@roywei
Copy link
Member

roywei commented Feb 19, 2019

@mxnet-label-bot add[Gluon, pr-awaiting-review]

@marcoabreu marcoabreu added Gluon pr-awaiting-review PR is waiting for code review labels Feb 19, 2019
wkcn
wkcn reviewed Feb 19, 2019
View reviewed changes
python/mxnet/gluon/nn/basic_layers.py
Parameters
----------
ngroups : int
Numnber of channel groups in GN.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
There is a typo 'numnber'.

@zhanghang1989 zhanghang1989 mentioned this pull request Feb 25, 2019
Closed
7 tasks
anirudhacharya
anirudhacharya reviewed Mar 3, 2019
View reviewed changes
tests/python/unittest/test_gluon.py
gn.initialize(ctx=ctx)
y = gn(x)
y = y.reshape(0, 4, -1)
print('y.mean(2) =', y.mean(2))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use logging.info instead of a print statement here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing out :)

@szha szha added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Mar 3, 2019
@karan6181
Copy link
Contributor

@zhanghang1989 Can you please address the review comments and try to merge this PR? Thanks!

@abhinavs95
Copy link
Contributor

@zhanghang1989 Could you please provide an update on the PR? Thanks

@zhanghang1989
Copy link
Contributor Author

Thanks for following up. We temporarily move it to gluon-cv.

@haojin2 haojin2 mentioned this pull request May 15, 2019
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wkcn wkcn wkcn left review comments

@anirudhacharya anirudhacharya anirudhacharya left review comments

@szha szha szha requested changes

Assignees
No one assigned
Labels
Gluon pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zhanghang1989 @roywei @karan6181 @abhinavs95 @szha @anirudhacharya @wkcn @marcoabreu