Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

min fix of 'storage_type' index mismatch #14560

Merged
merged 3 commits into from
Jun 8, 2019
Merged

min fix of 'storage_type' index mismatch #14560

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccede44
min fix of 'storage_type' index mismatch
Mar 29, 2019
c385c77
Merge remote-tracking branch 'upstream/master' into gss/min-fix
eric-haibin-lin May 5, 2019
4e232cd
Merge remote-tracking branch 'upstream/master' into gss/min-fix
eric-haibin-lin May 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/executor/graph_executor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,8 +1022,8 @@ void GraphExecutor::InitDataEntryMemory(std::vector<NDArray>* shared_pool) {
for (uint32_t i = 0; i < idx[nid].source->num_outputs(); ++i) {
auto eid = idx.entry_id(nid, i);
data_context[eid] = vctx[nid];
CHECK_NE(vstorage_type[nid], kUndefinedStorage);
data_storage_type[eid] = (NDArrayStorageType) vstorage_type[nid];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Is there any failed unit test you have at hand?

Copy link
Contributor Author

@gssplayer gssplayer May 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'am very sorry for no response on this question. I found this problem just by reading code, and had no any test. I've no runtime enviroment at hand. And I have to admit your CI is too complicate for me. Can anyone help to continue tracking this problem?

CHECK_NE(vstorage_type[eid], kUndefinedStorage);
data_storage_type[eid] = (NDArrayStorageType) vstorage_type[eid];
}
}

Expand Down