Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

min fix of 'storage_type' index mismatch #14560

Merged
merged 3 commits into from
Jun 8, 2019
Merged

min fix of 'storage_type' index mismatch #14560

merged 3 commits into from
Jun 8, 2019

Conversation

gssplayer
Copy link
Contributor

Index of array 'storage_type' should be indice of 'node entries',
not 'nodes'.

sign-of-by: [email protected]

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

min fix of 'storage_type' index mismatch
ccede44 
Index of array 'storage_type' should be indice of 'node entries',
not 'nodes'.

sign-of-by: [email protected]
@abhinavs95
Copy link
Contributor

Thank you for the fix @gssplayer Could you have a look at the CI failure?

@mxnet-label-bot add [Backend, pr-awaiting-review]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review labels Mar 29, 2019
@piyushghai
Copy link
Contributor

@gssplayer Can you look into the CI failures in order to take this PR forward ?

reminisce
reminisce approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@reminisce reminisce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM.

@reminisce
Copy link
Contributor

Please rebase and retrigger CI.

eric-haibin-lin
eric-haibin-lin reviewed Apr 17, 2019
View reviewed changes
src/executor/graph_executor.cc
@@ -947,8 +947,8 @@ void GraphExecutor::InitDataEntryMemory(std::vector<NDArray>* shared_pool) {
for (uint32_t i = 0; i < idx[nid].source->num_outputs(); ++i) {
auto eid = idx.entry_id(nid, i);
data_context[eid] = vctx[nid];
CHECK_NE(vstorage_type[nid], kUndefinedStorage);
data_storage_type[eid] = (NDArrayStorageType) vstorage_type[nid];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Is there any failed unit test you have at hand?

Copy link
Contributor Author

@gssplayer gssplayer May 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'am very sorry for no response on this question. I found this problem just by reading code, and had no any test. I've no runtime enviroment at hand. And I have to admit your CI is too complicate for me. Can anyone help to continue tracking this problem?

@roywei
Copy link
Member

roywei commented Apr 29, 2019

@gssplayer Thanks for the contribution, could you rebase your PR and trigger CI test again?

@abhinavs95
Copy link
Contributor

abhinavs95 commented May 30, 2019 •
edited
Loading

@gssplayer Could you have a look at the CI failure? You could try re-triggering it.

@abhinavs95
Copy link
Contributor

@mxnet-label-bot update [Backend, pr-awaiting-response]

@marcoabreu marcoabreu added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels May 30, 2019
@eric-haibin-lin
Copy link
Member

Triggered. hopefully it passes

@piyushghai
Copy link
Contributor

@gssplayer The CI passed :)

@eric-haibin-lin Can this PR be merged if it looks good ?

@eric-haibin-lin eric-haibin-lin merged commit e01c386 into apache:master Jun 8, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@gssplayer
min fix of 'storage_type' index mismatch (apache#14560)
dda5468 
Index of array 'storage_type' should be indice of 'node entries',
not 'nodes'.

sign-of-by: [email protected]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin left review comments

@reminisce reminisce reminisce approved these changes

Assignees
No one assigned
Labels
Backend Issues related to the backend of MXNet pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gssplayer @abhinavs95 @piyushghai @reminisce @roywei @eric-haibin-lin @marcoabreu