Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update MKL-DNN to fix the OSX build issue on master #14182

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Feb 16, 2019

Cherry picked #14141 from v1.4.x to master.

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
@TaoLv
Copy link
Member Author

TaoLv commented Feb 16, 2019

@szha @lanking520 @pengzhao-intel Picked #14141 from v1.4.x to master. MKL-DNN 0.18 update will be done via another PR after it passed all validation.

@ankkhedia
Copy link
Contributor

@TaoLv Thanks for your contribution!

@mxnet-label-bot add [pr-awaiting-review, MKLDNN, build]

@marcoabreu marcoabreu added Build MKLDNN pr-awaiting-review PR is waiting for code review labels Feb 16, 2019
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha szha merged commit d2cc396 into apache:master Feb 16, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build MKLDNN pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants