Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.4.x] Update MKL-DNN to fix the OSX build issue #14141

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Feb 13, 2019

Description

Find the issue description at: https://lists.apache.org/thread.html/1d5883444907f0a06d711d1f482feeadcbe1d523e9944e953a26cf51@%3Cdev.mxnet.apache.org%3E
and
oneapi-src/oneDNN#405

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv
Copy link
Member Author

TaoLv commented Feb 13, 2019

@TaoLv
Copy link
Member Author

TaoLv commented Feb 13, 2019

Weird CI failures.. :(

@ankkhedia
Copy link
Contributor

@TaoLv Thanks for your contribution! Could you please look into CI failures?

@mxnet-label-bot add [pr-awaiting-testing, MKLDNN, Build]

@marcoabreu marcoabreu added Build MKLDNN pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 13, 2019
@lanking520
Copy link
Member

Restarted :), @marcoabreu could you also grant CI access to @TaoLv so he will be able to retrigger the test next time

@piyushghai
Copy link
Contributor

@TaoLv
A unit test seems to be failing on this PR :

test_operator_gpu.test_stn
ValueError: threshold must be numeric and non-NAN, try sys.maxsize for untruncated representation

Not sure if this is related to your changes in this PR.

@lanking520
Copy link
Member

Retrigger the test again, not sure if there is an issue with Cent OS. But I do saw multiple failure in the Cent OS testing

@TaoLv
Copy link
Member Author

TaoLv commented Feb 14, 2019

Thank you for your attention @lanking520, @piyushghai. The test_stn issue was fixed on master branch several day ago: #14063. But the fix is not ported to v1.4.x branch.

@szha
Copy link
Member

szha commented Feb 14, 2019

@TaoLv I cherry-picked the fix. I will merge this PR if there's no other issue.

@szha
Copy link
Member

szha commented Feb 14, 2019

None looks related to mkldnn.

@szha szha merged commit 766ca04 into apache:v1.4.x Feb 14, 2019
@lanking520
Copy link
Member

@TaoLv Contribute back to master?

@TaoLv
Copy link
Member Author

TaoLv commented Feb 15, 2019

MKL-DNN 0.18 is coming soon: https://github.com/intel/mkl-dnn/releases/tag/v0.18-rc. We plan to update master directly to 0.18 release. Internal validation is WIP.

@szha
Copy link
Member

szha commented Feb 15, 2019

@TaoLv master pip build for mac mkl is still failing, so I'd recommend patching master too, ASAP.

@piyushghai
Copy link
Contributor

@TaoLv The OSX build from source is not working still. It's broken.

I tried a simple command : make -j4

@piyushghai
Copy link
Contributor

Update --> Ignore my previous comment. I resolved the issue thanks to @lanking520

TaoLv added a commit to TaoLv/incubator-mxnet that referenced this pull request Feb 16, 2019
* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
szha pushed a commit that referenced this pull request Feb 16, 2019
* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…ache#14182)

* update mkldnn to 0.17.x

* update mkldnn to 0.17.4

* empty commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build MKLDNN pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants