Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Simplify creation of NodeEntry instances and use emplace_back #14095

Merged
merged 4 commits into from
May 23, 2019
Merged

Simplify creation of NodeEntry instances and use emplace_back #14095

merged 4 commits into from
May 23, 2019

Commits on May 21, 2019

  1. Optimize move semantics of NodeEntry 

    apache/tvm#2576
Making copies of shared_ptr is more expensive than moving.
This PR reduces lock contention by using move semantics in NNVM nodes
making also more convenient to construct NodeEntry classes in the code
due to the added ctors.

Update NDarray with NodeEntry constructors and refine initializer lists.

Sync gradient.cc with tvm
    @larroy
    larroy committed May 21, 2019
    Configuration menu
    Copy the full SHA
    91f8c19 View commit details
    Browse the repository at this point in the history

  2. Remove additional calls to NodeEntry in emplace_back

    @larroy
    larroy committed May 21, 2019
    Configuration menu
    Copy the full SHA
    a79fdb0 View commit details
    Browse the repository at this point in the history

  3. refine patch

    @larroy
    larroy committed May 21, 2019
    Configuration menu
    Copy the full SHA
    7ef8e84 View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @larroy
    larroy committed May 21, 2019
    Configuration menu
    Copy the full SHA
    d6798ce View commit details
    Browse the repository at this point in the history