Optimize move semantics of NodeEntry reducing copies of shared_ptr wh… #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich causes atomic contention
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Feb 8, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Feb 8, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
5 tasks
tqchen
approved these changes
Feb 8, 2019
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Feb 11, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Feb 13, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Feb 13, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
libing4752
pushed a commit
to libing4752/tvm
that referenced
this pull request
Feb 18, 2019
…ich causes atomic contention (apache#2576)
merrymercy
pushed a commit
to merrymercy/tvm
that referenced
this pull request
Feb 18, 2019
…ich causes atomic contention (apache#2576)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
…ich causes atomic contention (apache#2576)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
…ich causes atomic contention (apache#2576)
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Mar 15, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 10, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 11, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 13, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 15, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 16, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 17, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 19, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 19, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 24, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 24, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 25, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 29, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
May 2, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
May 2, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
May 6, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
May 17, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
May 20, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
May 21, 2019
apache/tvm#2576 Making copies of shared_ptr is very expensive, 100x more than moving. This PR reduces lock contention by using move semantics in NNVM nodes
larroy
added a commit
to larroy/mxnet
that referenced
this pull request
May 21, 2019
apache/tvm#2576 Making copies of shared_ptr is more expensive than moving. This PR reduces lock contention by using move semantics in NNVM nodes making also more convenient to construct NodeEntry classes in the code due to the added ctors. Update NDarray with NodeEntry constructors and refine initializer lists. Sync gradient.cc with tvm
szha
pushed a commit
to apache/mxnet
that referenced
this pull request
May 23, 2019
* Optimize move semantics of NodeEntry apache/tvm#2576 Making copies of shared_ptr is more expensive than moving. This PR reduces lock contention by using move semantics in NNVM nodes making also more convenient to construct NodeEntry classes in the code due to the added ctors. Update NDarray with NodeEntry constructors and refine initializer lists. Sync gradient.cc with tvm * Remove additional calls to NodeEntry in emplace_back * refine patch * Fix lint
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…#14095) * Optimize move semantics of NodeEntry apache/tvm#2576 Making copies of shared_ptr is more expensive than moving. This PR reduces lock contention by using move semantics in NNVM nodes making also more convenient to construct NodeEntry classes in the code due to the added ctors. Update NDarray with NodeEntry constructors and refine initializer lists. Sync gradient.cc with tvm * Remove additional calls to NodeEntry in emplace_back * refine patch * Fix lint
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ich causes atomic contention
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.