This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNet Scala] make dependencies required for compile time #13835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushghai
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
Tested it out with java-demo package that was breaking before this change.
Works now.
Thanks for the quick turnaround on this @lanking520
zachgk
approved these changes
Jan 10, 2019
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Jan 11, 2019
* upstream/master: (109 commits) Code modification for testcases of various network models in directory example (apache#12498) [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818) fix Makefile for rpkg (apache#13590) change to compile time (apache#13835) Disabled flaky test (apache#13758) Improve license_header tool by only traversing files under revision c… (apache#13803) Removes unneeded nvidia driver ppa installation (apache#13814) Add Local test stage and option to jump directly to menu item from commandline (apache#13809) Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830) Fix scala doc build break for v1.3.1 (apache#13820) [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794) [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678) onnx export ops (apache#13821) [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676) fix minor indentation (apache#13827) Fixing a symlink issue with R install (apache#13708) remove useless code (apache#13777) ONNX ops: norm exported and lpnormalization imported (apache#13806) Add new Maven build for Scala package (apache#13819) Dockerfiles for Publish Testing (apache#13707) ...
piyushghai
pushed a commit
to piyushghai/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 26, 2019
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 26, 2019
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 30, 2019
zachgk
pushed a commit
to zachgk/incubator-mxnet
that referenced
this pull request
May 16, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for maven deploy. Make the depencies from runtime to compile time.
@piyushghai @frankfliu @gigasquid @andrewfayres @zachgk
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.