[MXNET-1260] Float64 DType computation support in Scala/Java #13678

piyushghai · 2018-12-18T21:54:40Z

Description

This PR introduces Float64/Double data type support in NDArrays in Scala. Currently we only allow precision upto Float32 in Scala as a result of which there are issues when one tries to load a model trained using float64 (in another language binding).

This also fixes two long standing issues : fixes #11315 & fixes #10338

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

Interesting edge cases to note here
Need to complete the F64 support in other classes as well, and then test out and compare training of a model using float32 and float64. The comparison would be in terms of the precision of the loss, accuracy of the trained model, memory occupied by the model during training process.

piyushghai · 2018-12-18T21:54:58Z

@andrewfayres @lanking520 @zachgk

Roshrini · 2018-12-18T23:28:00Z

@mxnet-label-bot Add [pr-work-in-progress, Scala]

lanking520

Please add some Scala test cases

piyushghai · 2018-12-19T04:44:30Z

@lanking520 I have already added the Scala tests in NDArraySuite.scala class. It's in this commit : 5529f94

lanking520

Thanks to your great contribution! Overall look clean and tidy!

scala-package/core/src/main/scala/org/apache/mxnet/MX_PRIMITIVES.scala

scala-package/core/src/main/scala/org/apache/mxnet/NDArray.scala

piyushghai · 2019-01-03T23:12:23Z

@mxnet-label-bot remove [pr-work-in-progress]

piyushghai · 2019-01-03T23:13:08Z

@mxnet-label-bot Add [pr-awaiting-review]

lanking520

LGTM

scala-package/core/src/main/scala/org/apache/mxnet/javaapi/NDArray.scala

scala-package/core/src/test/scala/org/apache/mxnet/IOSuite.scala

…ature, and public methods calling the Impls

….scala for creating a new DataIterator

This reverts commit 9d7c3ce.

…ons in NDArrays. (These ops were already supported in the previous versions)

…ded integration tests for it

…ssible input

andrewfayres

LGTM

lanking520 · 2019-01-10T19:58:27Z

@piyushghai please Satisfy the lint god (╯‵□′)╯︵┻━┻

lanking520 · 2019-01-10T21:13:22Z

@piyushghai please Satisfy the lint god (‵□′)

* upstream/master: (109 commits) Code modification for testcases of various network models in directory example (apache#12498) [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818) fix Makefile for rpkg (apache#13590) change to compile time (apache#13835) Disabled flaky test (apache#13758) Improve license_header tool by only traversing files under revision c… (apache#13803) Removes unneeded nvidia driver ppa installation (apache#13814) Add Local test stage and option to jump directly to menu item from commandline (apache#13809) Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830) Fix scala doc build break for v1.3.1 (apache#13820) [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794) [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678) onnx export ops (apache#13821) [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676) fix minor indentation (apache#13827) Fixing a symlink issue with R install (apache#13708) remove useless code (apache#13777) ONNX ops: norm exported and lpnormalization imported (apache#13806) Add new Maven build for Scala package (apache#13819) Dockerfiles for Publish Testing (apache#13707) ...

…pache#13678)" This reverts commit ed7ca26.

…13678) * Added Float64 as a supported datatype in NDArray * Added unit tests for Float64 in NDArray * Fix for failing Clojure unit tests * Added Float and Double as MX_PRIMITIVES for computation in Scala * Trying out second approach --> Private Impl methods with generic signature, and public methods calling the Impls * Fixed errors in *= method * Added Float64 in IO.scala and DataIter.scala * Added another testcase for IO.DataDesc creation * Fixed failing CI * Added Float64 in Predictor class * Added Float64 in Classifier class * Added Double as a possible return type to : classifyWithNDArray * Added unit tests for Classifier and Predictor.scala classes for Float64/Double * Approach 3 --> Using a trait to mirror Float and Double in Scala * Added comments on MX_PRIMITIVES.scala * Added Float64/Double support for inference in ImageClassifier APIs * Added unary- and compareTo in MX_NUMBER_LIKE * Renamed MX_NUMBER_LIKE to MX_PRIMITIVE_TYPE * Fixed linting issue * Now specifying dType from the available data in copyTo and MXDataIter.scala for creating a new DataIterator * Add primitives support handling to the generator for proper conversion * Reduced code duplication in classify method in Classifier.scala * Fix infer package for new signatures and address some bugs * Removed code duplication in getPixelsArray * remove debugging * Changed classifyWithNDArray method in Classifier.scala * Removed code duplication in predictImpl * Satisfying lint god _/\_ * Fixed failing PredictorSuite test * Renamed MX_FLOAT to Camel case * Revert "Renamed MX_FLOAT to Camel case" This reverts commit 9d7c3ce. * Added an implicit conversion from int--> float to support int operations in NDArrays. (These ops were already supported in the previous versions) * Added Float64 as a training option to ImClassification Suite. Also added integration tests for it * Satisfy Lint God _/\_ * Added Float64 support in Java NDArray * Added Float64 support in Java's Predictor API * Added yours truly to the Contributors list * Added method comments on Predictor.predict with Array[Double] as a possible input * Added method comments explaining what MX_PRIMITIVE_TYPE is * Fixed errors cause by rebasing with master * Added licences to the files

piyushghai requested review from nswamy and yzhliu as code owners December 18, 2018 21:54

marcoabreu added pr-work-in-progress PR is still work in progress Scala labels Dec 18, 2018

piyushghai requested a review from gigasquid as a code owner December 19, 2018 00:18

lanking520 reviewed Dec 19, 2018

View reviewed changes

piyushghai force-pushed the float64 branch from ce86632 to e564656 Compare December 21, 2018 17:58

piyushghai changed the title ~~[MXNET-1260] [WIP] [DO NOT MERGE] Float64 support in NDArray in Scala~~ [MXNET-1260] [WIP] Float64 support in NDArray in Scala Dec 27, 2018

piyushghai force-pushed the float64 branch from ea527bc to 926871e Compare December 28, 2018 17:47

lanking520 reviewed Dec 29, 2018

View reviewed changes

scala-package/core/src/main/scala/org/apache/mxnet/MX_PRIMITIVES.scala Show resolved Hide resolved

scala-package/core/src/main/scala/org/apache/mxnet/NDArray.scala Show resolved Hide resolved

piyushghai force-pushed the float64 branch from 9d7c3ce to e113a24 Compare January 2, 2019 19:22

piyushghai changed the title ~~[MXNET-1260] [WIP] Float64 support in NDArray in Scala~~ [MXNET-1260] Float64 DType computation support in Scala Jan 3, 2019

marcoabreu removed the pr-work-in-progress PR is still work in progress label Jan 3, 2019

marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 3, 2019

piyushghai changed the title ~~[MXNET-1260] Float64 DType computation support in Scala~~ [MXNET-1260] Float64 DType computation support in Scala/Java Jan 4, 2019

piyushghai force-pushed the float64 branch from 65bf692 to cbda37e Compare January 8, 2019 00:41

piyushghai mentioned this pull request Jan 8, 2019

[MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs #13794

Merged

4 tasks

lanking520 approved these changes Jan 9, 2019

View reviewed changes

zachgk approved these changes Jan 10, 2019

View reviewed changes

andrewfayres reviewed Jan 10, 2019

View reviewed changes

scala-package/core/src/main/scala/org/apache/mxnet/javaapi/NDArray.scala Show resolved Hide resolved

scala-package/core/src/test/scala/org/apache/mxnet/IOSuite.scala Show resolved Hide resolved

piyushghai added 5 commits January 10, 2019 11:43

Added Float64 as a supported datatype in NDArray

4aabf1e

Added unit tests for Float64 in NDArray

002720c

Fix for failing Clojure unit tests

96f2849

Added Float and Double as MX_PRIMITIVES for computation in Scala

8754e41

Trying out second approach --> Private Impl methods with generic sign…

d92840a

…ature, and public methods calling the Impls

piyushghai and others added 20 commits January 10, 2019 11:44

Now specifying dType from the available data in copyTo and MXDataIter…

c9a0261

….scala for creating a new DataIterator

Add primitives support handling to the generator for proper conversion

07bd464

Reduced code duplication in classify method in Classifier.scala

c9fc37a

Fix infer package for new signatures and address some bugs

32b8d99

Removed code duplication in getPixelsArray

b450355

Changed classifyWithNDArray method in Classifier.scala

8167005

Removed code duplication in predictImpl

422f9de

Satisfying lint god _/\_

fdc8a1e

remove debugging

e5a5bfe

Fixed failing PredictorSuite test

db77274

Renamed MX_FLOAT to Camel case

72a734b

Revert "Renamed MX_FLOAT to Camel case"

c67e2dc

This reverts commit 9d7c3ce.

Added an implicit conversion from int--> float to support int operati…

50abf88

…ons in NDArrays. (These ops were already supported in the previous versions)

Added Float64 as a training option to ImClassification Suite. Also ad…

3b52b50

…ded integration tests for it

Satisfy Lint God _/\_

ddc8e78

Added Float64 support in Java NDArray

3d85167

Added Float64 support in Java's Predictor API

29bd834

Added yours truly to the Contributors list

b7f851e

Added method comments on Predictor.predict with Array[Double] as a po…

e329ee4

…ssible input

Added method comments explaining what MX_PRIMITIVE_TYPE is

69c35b3

piyushghai force-pushed the float64 branch from cbda37e to 69c35b3 Compare January 10, 2019 19:44

andrewfayres approved these changes Jan 10, 2019

View reviewed changes

Fixed errors cause by rebasing with master

fa9fb45

Added licences to the files

e562e94

lanking520 merged commit ed7ca26 into apache:master Jan 10, 2019

piyushghai added a commit to piyushghai/incubator-mxnet that referenced this pull request Jan 22, 2019

Revert "[MXNET-1260] Float64 DType computation support in Scala/Java (a…

dc54202

…pache#13678)" This reverts commit ed7ca26.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MXNET-1260] Float64 DType computation support in Scala/Java #13678

[MXNET-1260] Float64 DType computation support in Scala/Java #13678

piyushghai commented Dec 18, 2018 •

edited

Loading

piyushghai commented Dec 18, 2018

Roshrini commented Dec 18, 2018

lanking520 left a comment

piyushghai commented Dec 19, 2018

lanking520 left a comment

piyushghai commented Jan 3, 2019

piyushghai commented Jan 3, 2019

lanking520 left a comment

andrewfayres left a comment

lanking520 commented Jan 10, 2019

lanking520 commented Jan 10, 2019

[MXNET-1260] Float64 DType computation support in Scala/Java #13678

[MXNET-1260] Float64 DType computation support in Scala/Java #13678

Conversation

piyushghai commented Dec 18, 2018 • edited Loading

Description

Checklist

Essentials

Comments

piyushghai commented Dec 18, 2018

Roshrini commented Dec 18, 2018

lanking520 left a comment

Choose a reason for hiding this comment

piyushghai commented Dec 19, 2018

lanking520 left a comment

Choose a reason for hiding this comment

piyushghai commented Jan 3, 2019

piyushghai commented Jan 3, 2019

lanking520 left a comment

Choose a reason for hiding this comment

andrewfayres left a comment

Choose a reason for hiding this comment

lanking520 commented Jan 10, 2019

lanking520 commented Jan 10, 2019

piyushghai commented Dec 18, 2018 •

edited

Loading