-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1253] [WIP] Fix large array issue in topk operator #13667
Conversation
@apeforest Thanks for working on this. |
@@ -58,7 +58,6 @@ struct TopKParam : public dmlc::Parameter<TopKParam> { | |||
int k; | |||
int ret_typ; | |||
bool is_ascend; | |||
int dtype; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an incompatible change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. could you please revert the change?
@apeforest Can you address comments and rebase this PR? Thanks |
@apeforest ping again for the update |
Got fully occupied with another project. I will resume this PR when I get some slack next week. |
@apeforest Did you get a chance to work on this PR? |
@apeforest Any updates? |
@apeforest Can you rebase with the current master branch and look into the CI failures ? |
@apeforest Any update on this PR? |
1 similar comment
@apeforest Any update on this PR? |
@access2rohit is working on this in a new PR. Closing this one. |
Description
This is a second batch of fixes for several sorting operators.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments