Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-895] ONNX import/export: TopK #13627

Merged
merged 7 commits into from
Aug 29, 2019
Merged

[MXNET-895] ONNX import/export: TopK #13627

merged 7 commits into from
Aug 29, 2019

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Dec 12, 2018 •
edited
Loading

Description

Add support to import/export TopK.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • import, export, unit test

Comments

@vandanavk vandanavk requested a review from szha as a code owner December 12, 2018 18:34
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [ONNX, pr-work-in-progress]

@marcoabreu marcoabreu added ONNX pr-work-in-progress PR is still work in progress labels Dec 12, 2018
@vandanavk vandanavk force-pushed the topk_onnx branch 4 times, most recently from d9066bb to 66a5cee Compare December 13, 2018 21:23
@anirudhacharya
Copy link
Member

can you please update the PR description?

@vandanavk
Copy link
Contributor Author

This PR depends on PR #13667

@vandanavk
Copy link
Contributor Author

Closing this PR for now, will reopen once #13667 is merged

@vandanavk vandanavk closed this Dec 18, 2018
@vandanavk vandanavk reopened this Dec 21, 2018
@vandanavk vandanavk changed the title [WIP] [MXNET-895] ONNX import/export: TopK [MXNET-895] ONNX import/export: TopK Dec 22, 2018
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Dec 22, 2018
@vandanavk vandanavk force-pushed the topk_onnx branch 2 times, most recently from dc01588 to ffb5126 Compare December 28, 2018 21:51
@anirudhacharya
Copy link
Member

@vandanavk can you please rebase and resolve conflicts

@sandeep-krishnamurthy sandeep-krishnamurthy added the pr-work-in-progress PR is still work in progress label Jan 26, 2019
@ankkhedia ankkhedia mentioned this pull request Feb 14, 2019
Closed
7 tasks
@pinaraws
Copy link

@vandanavk Is this ready for review? @Roshrini Can you please take a look?

@vandanavk
Copy link
Contributor Author

@pinaraws this is ready for review, but can be merged only after #13667

@piyushghai
Copy link
Contributor

@vandanavk Gentle ping...

@vandanavk
Copy link
Contributor Author

@piyushghai No more changes are required in this PR. I'm waiting for #13667 to get merged.

@pinaraws
Copy link

Waiting on #13667 to get merged

@Roshrini
Copy link
Member

Waiting on #15170 to move forward

@vandanavk
Copy link
Contributor Author

@mxnet-label-bot remove [pr-work-in-progress]

@marcoabreu marcoabreu removed the pr-work-in-progress PR is still work in progress label Jul 11, 2019
@vandanavk
Copy link
Contributor Author

@zhreshold @anirudhacharya for review

@karan6181
Copy link
Contributor

@zhreshold @anirudhacharya Could you please review this PR and get it resolved? Thanks!

@piyushghai
Copy link
Contributor

@anirudhacharya Bouncing for review...

@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [pr-awaiting-merge, ONNX]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Aug 24, 2019
@Roshrini Roshrini merged commit b7cca01 into apache:master Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roshrini Roshrini Roshrini approved these changes

@anirudhacharya anirudhacharya anirudhacharya approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vandanavk @anirudhacharya @pinaraws @piyushghai @Roshrini @karan6181 @sandeep-krishnamurthy @marcoabreu