This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1235] Add a test for AdaMax optimizer #13467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [Test, pr-awaiting-review] |
sandeep-krishnamurthy
approved these changes
Dec 1, 2018
|
@anirudhacharya for another round of review |
|
LGTM
…On Sun, Dec 2, 2018, 7:36 PM Vandana Kannan ***@***.*** wrote:
@anirudhacharya <https://github.com/anirudhacharya> for another round of
review
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13467 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACpk5em_030MMn2bT5MNuxUw-ydqZhWIks5u1JxHgaJpZM4Y6jD4>
.
|
|
@mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* Add a test for AdaMax optimizer * Modify nested for loop with itertools.product and left tolerance to default * Trigger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In issue #10923 it was mentioned that some optimizers do not have tests. AdaMax was one of them. One test was added.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments