Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Many operators don't have unit tests. #10923

Open
zheng-da opened this issue May 13, 2018 · 12 comments
Open

Many operators don't have unit tests. #10923

zheng-da opened this issue May 13, 2018 · 12 comments

Comments

@zheng-da
Copy link
Contributor

Our Python unit tests don't cover all operators. Recently, I found softmax activation was never tested and the test has been added in #10918. Currently, the backward computation of norm doesn't have GPU tests. I'm afraid more operators don't have unit tests.

@eric-haibin-lin eric-haibin-lin changed the title some operators don't have unit tests. Many operators don't have unit tests. May 13, 2018
@eric-haibin-lin
Copy link
Member

Also #10868

@eric-haibin-lin
Copy link
Member

We need to make a list tracking missing unit tests

@zheng-da
Copy link
Contributor Author

zheng-da commented May 13, 2018

can we create a list and somehow still keep track of them?
not sure doing something like below is a good way.

  • norm backward

@anirudhacharya
Copy link
Member

  • check_numeric_gradient for FFT operator

@anirudhacharya
Copy link
Member

anirudhacharya commented Oct 29, 2018

initializer.py has very less test coverage

  • Orthogonal Initializer
  • Bilinear Initializer
  • MSRAPrelu Initializer
  • Mixed Initializer

@anirudhacharya
Copy link
Member

Missing Gradient Checks - #13254

@apeforest
Copy link
Contributor

apeforest commented Nov 14, 2018

@mxnet-label-bot add [Good First Issue]

@anirudhacharya
Copy link
Member

anirudhacharya commented Nov 19, 2018

Missing Optimizer tests -

  • Large batch BSGD
  • Delay compensation asynchronous SGD
  • SGLD
  • AdaDelta
  • Adamax
  • Nadam

@hanzhaogang
Copy link

hanzhaogang commented Nov 21, 2018

@zheng-da What skills and knowledge are required to write the test code? How do we test operators? Checked the test_subgraph_op.py whihc I think should be a test for the subgraph operator in the incubator-mxnet/tests/python/unittest/ package but still have no idea how to contribute.

@cchung100m
Copy link
Contributor

Missing Optimizer tests -

  • Large batch BSGD
  • Delay compensation asynchronous SGD
  • SGLD
  • AdaDelta
  • Adamax
  • Nadam

Hi @anirudhacharya ,

It's been a while since the checked missing unit tests last year, and I checked Nadam has test, I would appreciate if you can point me where can I find the latest list of missing unit tests.

Many thanks,

@anirudhacharya
Copy link
Member

@cchung100m I am afraid this is the only list of missing unit tests. I have updated the list based on my knowledge.

@anirudh2290
Copy link
Member

anirudh2290 commented Aug 8, 2019

  • sequence reverse op (gpu unit tests)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants