refactor(runtime): extract active compact facts - #1259
Merged
Astro-Han merged 1 commit intoJul 20, 2026
Merged
Conversation
23 tasks
xuruiray
marked this pull request as ready for review
July 20, 2026 07:33
xuruiray
force-pushed
the
agent/refactor-active-full-compact-facts
branch
from
July 20, 2026 11:15
0a40051 to
279b9e8
Compare
Astro-Han
approved these changes
Jul 20, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
No concrete findings. The extraction preserves the fact-builder behavior and public delegation, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
active-full-compact-facts.tsRefs #1084
This is the
active-full-compact.tsfact-extraction checkbox only. It is flat off currentmainand does not depend on #1258.Behavior
Behavior- and visually-neutral. The regexes, filtering order, stable serialization, budgets, fallback text, optional-field drop order, and public exports are preserved.
Validation
npm test --workspace @maka/runtime— 2265 passed, 7 skipped, 0 failednpm run typecheck— passednpm run lint— passedgit diff --check— passednpm test— all feature-relevant workspaces passed; parallel runner reported runtime-host and CLI failuresnpm test --workspace @maka/runtime-host— 45/45 passedKnown independent baseline
On this flat-off-main branch,
npm test --workspace maka-agentis 629/631: the two failures are the exactnode:sqlitestderr pollution tracked in #1257 and fixed independently by #1258. This PR intentionally does not stack that fix.