fix(storage): defer sqlite runtime loading - #1258
Merged
Astro-Han merged 2 commits intoJul 20, 2026
Merged
Conversation
xuruiray
marked this pull request as ready for review
July 20, 2026 07:33
xuruiray
force-pushed
the
agent/fix-storage-sqlite-warning
branch
from
July 20, 2026 11:15
9c9ff12 to
b678ced
Compare
xuruiray
added a commit
to xuruiray/maka-agent
that referenced
this pull request
Jul 20, 2026
Summary: - add a visual capture of the clean top-level storage import Rationale: - make the before/after behavior visible in PR apache#1258 Tests: - node --input-type=module -e "await import('./packages/storage/dist/index.js')" - verified exit code 0 and stderr byte count 0 Co-authored-by: Codex <codex@openai.com>
xuruiray
marked this pull request as draft
July 20, 2026 11:30
xuruiray
added a commit
to xuruiray/maka-agent
that referenced
this pull request
Jul 20, 2026
Summary: - add a visual capture of the clean top-level storage import Rationale: - make the before/after behavior visible in PR apache#1258 Tests: - node --input-type=module -e "await import('./packages/storage/dist/index.js')" - verified exit code 0 and stderr byte count 0 Co-authored-by: Codex <codex@openai.com>
xuruiray
force-pushed
the
agent/fix-storage-sqlite-warning
branch
from
July 20, 2026 11:31
333c14d to
4d80a13
Compare
Summary: - add a visual capture of the clean top-level storage import Rationale: - make the before/after behavior visible in PR apache#1258 Tests: - node --input-type=module -e "await import('./packages/storage/dist/index.js')" - verified exit code 0 and stderr byte count 0 Co-authored-by: Codex <codex@openai.com>
xuruiray
force-pushed
the
agent/fix-storage-sqlite-warning
branch
from
July 20, 2026 11:40
4d80a13 to
6e93171
Compare
xuruiray
marked this pull request as ready for review
July 20, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:sqliteuntil a SQLite store is actually constructed@maka/storageexports and synchronous store API unchangedCloses #1257
Evidence
Before/after: the same Maka CLI startup command (
node packages/cli/dist/cli.js --help) prints the SQLite warning onmainbut exits with an empty stderr stream on this PR.Validation
main— exit code 0, stderr 168 bytes with SQLite ExperimentalWarningnpm test --workspace @maka/storage— 397 passed, 1 skipped, 0 failednpm test --workspace maka-agent— 631 passed, 0 failednpm run typecheck— passednpm run lint— passedgit diff --check— passednpm test— all workspaces passed except runtime-host in the parallel runner; immediate isolatednpm test --workspace @maka/runtime-hostpassed 45/45