Rename the generated apijar files to -api.jar

[dweiss]

No description provided.

[rmuir]

Looks good. I expect dev-tools/scripts/smokeTestRelease.py:630 to complain, but we can fix it.

[dweiss]

Looks good. I expect dev-tools/scripts/smokeTestRelease.py:630 to complain, but we can fix it.

I think this only checks the top-level files? I keep an eye on the nightly run for this so if it complains, I'll follow-up.

[rmuir]

@dweiss here would be my proposed mod (a bit hacky, but it should do the trick if we need)

diff --git a/dev-tools/scripts/smokeTestRelease.py b/dev-tools/scripts/smokeTestRelease.py
index fbcb0586cd2..17b816162fc 100755
--- a/dev-tools/scripts/smokeTestRelease.py
+++ b/dev-tools/scripts/smokeTestRelease.py
@@ -633,7 +633,7 @@ def verifyUnpacked(java: Any, artifact: str, unpackPath: str, gitRevision: str,
 
   if isSrc:
     print("    make sure no JARs/WARs in src dist...")
-    lines = os.popen("find . -name \\*.jar").readlines()
+    lines = os.popen("find . -name \\*.jar -not -name \\*-api.jar").readlines()
     if len(lines) != 0:
       print("    FAILED:")
       for line in lines:

[dweiss]

Oh, I see it now. I'll add it with the reference to this issue.

[dweiss]

Checking if smoke tester is happy -
https://github.com/apache/lucene/actions/workflows/run-nightly-smoketester.yml

[uschindler]

OK.