Skip to content

build: enable more of javac 24's lints, fix some issues#14907

Merged
rmuir merged 2 commits intoapache:mainfrom
rmuir:javac_24_lints
Jul 7, 2025
Merged

build: enable more of javac 24's lints, fix some issues#14907
rmuir merged 2 commits intoapache:mainfrom
rmuir:javac_24_lints

Conversation

@rmuir
Copy link
Member

@rmuir rmuir commented Jul 7, 2025

Let's maximize what javac gives. I revisited all the disabled ones too, the only ones still disabled are the ones that are a real PITA to fix.

Let's maximize what javac gives. I revisited all the disabled ones too,
the only ones still disabled are the ones that are a real PITA to fix.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@rmuir rmuir merged commit b47ba97 into apache:main Jul 7, 2025
9 checks passed
@dweiss
Copy link
Contributor

dweiss commented Jul 7, 2025

Java 25 and on complain with this:

> Task :lucene:core:compileMain24Java FAILED
warning: [path] Unexpected extension for archive file: /home/jenkins/workspace/Lucene-main-Linux/lucene/core/src/generated/jdk/jdk24.apijar
error: warnings found and -Werror specified
1 error
1 warning

@rmuir
Copy link
Member Author

rmuir commented Jul 7, 2025

@dweiss thank you, let's just disable that one for now then.

@dweiss
Copy link
Contributor

dweiss commented Jul 7, 2025

No, wait - I think it's better to just rename those apijar files to something more palatable. Working on it.

@rmuir
Copy link
Member Author

rmuir commented Jul 7, 2025

even better. I honestly haven't dug into this check, but it seems like a really great sanity check for the build system. As we've seen, the tools don't always fail clearly if you pass them crazy inputs.

@dweiss
Copy link
Contributor

dweiss commented Jul 7, 2025

#14909 should do it.

Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants