build: enable more of javac 24's lints, fix some issues#14907
build: enable more of javac 24's lints, fix some issues#14907rmuir merged 2 commits intoapache:mainfrom
Conversation
Let's maximize what javac gives. I revisited all the disabled ones too, the only ones still disabled are the ones that are a real PITA to fix.
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
Java 25 and on complain with this: |
|
@dweiss thank you, let's just disable that one for now then. |
|
No, wait - I think it's better to just rename those apijar files to something more palatable. Working on it. |
|
even better. I honestly haven't dug into this check, but it seems like a really great sanity check for the build system. As we've seen, the tools don't always fail clearly if you pass them crazy inputs. |
|
#14909 should do it. |
Let's maximize what javac gives. I revisited all the disabled ones too, the only ones still disabled are the ones that are a real PITA to fix.