Skip to content

[KYUUBI #689] Fix MetricsSystemSuite on JDK 11 #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 3 commits into from
Closed

[KYUUBI #689] Fix MetricsSystemSuite on JDK 11 #690

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1762f92
Fix MetricsSystemSuite on G1
pan3793 Jun 13, 2021
ab103cf
[GA] Enable JDK 11 in GA
pan3793 Jun 13, 2021
bd64a66
Revert "[GA] Enable JDK 11 in GA"
pan3793 Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kyuubi-metrics/src/test/scala/org/apache/kyuubi/metrics/MetricsSystemSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class MetricsSystemSuite extends KyuubiFunSuite {
val client: HttpClient = new HttpClient
client.start()
val res: ContentResponse = client.GET(prometheusHttpServer.getURI.resolve(testContextPath))
assert(res.getContentAsString.contains("PS_MarkSweep_count"))
assert(res.getContentAsString.contains("heap_usage"))
assert(res.getContentAsString.contains("kyuubi_connection_opened 2021.0"))
client.stop()

Expand All @@ -83,7 +83,7 @@ class MetricsSystemSuite extends KyuubiFunSuite {
metricsSystem.initialize(conf)
metricsSystem.start()
val reportFile = Paths.get(reportPath.toString, "report.json")
checkJsonFileMetrics(reportFile, "PS-MarkSweep.count")
checkJsonFileMetrics(reportFile, "heap.usage")
metricsSystem.incCount(MetricsConstants.STATEMENT_TOTAL)

checkJsonFileMetrics(reportFile, MetricsConstants.STATEMENT_TOTAL)
Expand Down