Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Jun 13, 2021

Why are the changes needed?

Fix #689.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793 pan3793 changed the title [KYUUBI #689] Fix MetricsSystemSuite on JDK 11 [WIP][KYUUBI #689] Fix MetricsSystemSuite on JDK 11 Jun 13, 2021
@pan3793 pan3793 self-assigned this Jun 13, 2021
@pan3793 pan3793 marked this pull request as draft June 13, 2021 10:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #690 (7c4d258) into master (b3715c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 7c4d258 differs from pull request most recent head bd64a66. Consider uploading reports for the commit bd64a66 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   80.51%   80.51%           
=======================================
  Files         122      122           
  Lines        4738     4738           
  Branches      574      574           
=======================================
  Hits         3815     3815           
  Misses        601      601           
  Partials      322      322           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3715c1...bd64a66. Read the comment docs.

@pan3793 pan3793 changed the title [WIP][KYUUBI #689] Fix MetricsSystemSuite on JDK 11 [KYUUBI #689] Fix MetricsSystemSuite on JDK 11 Jun 13, 2021
@pan3793 pan3793 marked this pull request as ready for review June 13, 2021 11:17
@pan3793 pan3793 added the Test label Jun 13, 2021
@pan3793 pan3793 added this to the v1.3.0 milestone Jun 13, 2021
Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaooqinn yaooqinn closed this in a1cc06c Jun 13, 2021
@pan3793 pan3793 deleted the 689 branch June 14, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JDK11] Fix MetricsSystemSuite

3 participants