Add metrics for SSL keystore expiration time #6866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
keystore_expire
branch
from
1707a96 to
3cb6146
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6866 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 688 +1
Lines 42504 42545 +41
Branches 5798 5800 +2
======================================
- Misses 42504 42545 +41 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Dec 26, 2024
kyuubi-metrics/src/main/scala/org/apache/kyuubi/metrics/MetricsConstants.scala
Outdated
Show resolved
Hide resolved
turboFei
force-pushed
the
keystore_expire
branch
2 times, most recently
from
9335f05 to
d550e91
Compare
turboFei
force-pushed
the
keystore_expire
branch
from
d550e91 to
77c6db0
Compare
pan3793
pushed a commit
that referenced
this pull request
Dec 26, 2024
### Why are the changes needed? Add metrics for SSL keystore expiration, then we can add alert if the keystore will expire in 1 month. ### How was this patch tested? Integration testing. <img width="1721" alt="image" src="https://github.com/user-attachments/assets/f4ef6af6-923b-403c-a80d-06dbb80dbe1c" /> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6866 from turboFei/keystore_expire. Closes #6866 77c6db0 [Wang, Fei] Add metrics for SSL keystore expiration time #6866 Authored-by: Wang, Fei <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 53034a3) Signed-off-by: Cheng Pan <[email protected]>
Member
|
thanks, merged to master/1.10 |
This was referenced Dec 26, 2024
turboFei
added a commit
that referenced
this pull request
Dec 27, 2024
…ift binary SSL and thrift http SSL enabled ### Why are the changes needed? Followup for #6866 It would throw exception if both thrift binary SSL and thrift http SSL enabled ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6872 from turboFei/duplicate_gauge. Closes #6866 ea35676 [Wang, Fei] prevent conflicts 982f175 [Wang, Fei] conflicts Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
turboFei
added a commit
that referenced
this pull request
Dec 27, 2024
…ift binary SSL and thrift http SSL enabled ### Why are the changes needed? Followup for #6866 It would throw exception if both thrift binary SSL and thrift http SSL enabled ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6872 from turboFei/duplicate_gauge. Closes #6866 ea35676 [Wang, Fei] prevent conflicts 982f175 [Wang, Fei] conflicts Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit 164df8d) Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Add metrics for SSL keystore expiration, then we can add alert if the keystore will expire in 1 month.
How was this patch tested?
Integration testing.
Was this patch authored or co-authored using generative AI tooling?
No.