Skip to content

Add more metrics for grafana dashboard #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
turboFei wants to merge 19 commits into from
Closed

Add more metrics for grafana dashboard #6870

turboFei wants to merge 19 commits into from

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Dec 26, 2024 •
edited
Loading

Why are the changes needed?

Add more metrics for monitoring.

How was this patch tested?

  1. Overall
    image2. Connection(repeat for connectionType - thrift_binary_connection,rest_connection,thrift_http_connection,metadata_request)
    For example:
image image image
  1. Operation(repeat for operationType - ExecuteStatement,BatchJobSubmission,LaunchEngine)
image image
  1. Extra
image
  1. Move the JVM statistics down.

Was this patch authored or co-authored using generative AI tooling?

No.

@turboFei turboFei changed the title Grafana metrics Add more metrics for grafana dashboard Dec 26, 2024
@pan3793
Copy link
Member

pan3793 commented Dec 26, 2024 •
edited
Loading

Thanks for making this change, I apply it in Grafana v9.0.8 and it works well.

One suggestion, can we apply increase for MetadataRequest panel?
image

@pan3793
Copy link
Member

pan3793 commented Dec 26, 2024

btw, I think we should keep the 1m trend interval, "x times per minute" is a very common concept

@pan3793
Copy link
Member

pan3793 commented Dec 26, 2024

test failure looks related to #6865

@pan3793
Copy link
Member

pan3793 commented Dec 26, 2024

Some JVM panels seem does not work for Java17, which can be fixed later independently.

@turboFei turboFei mentioned this pull request Dec 26, 2024
Closed
@turboFei
Copy link
Member Author

turboFei commented Dec 26, 2024

Some JVM panels seem does not work for Java17, which can be fixed later independently.

image

btw, I think we should keep the 1m trend interval, "x times per minute" is a very common concept

Ok

@turboFei
Copy link
Member Author

turboFei commented Dec 26, 2024 •
edited
Loading

Also add total connections in the overview for multiple kyuubi instances use case, should be general.
image

@pan3793 It should be almost done.

@turboFei
Copy link
Member Author

turboFei commented Dec 26, 2024

GC Count for increase instead of total

image

@turboFei
Copy link
Member Author

turboFei commented Dec 26, 2024

Added keystore expiration:
image

@turboFei
Copy link
Member Author

turboFei commented Dec 26, 2024

If you select ALL for the connType or `opType, it will repeat the rows.
image

@turboFei turboFei requested a review from yaooqinn December 26, 2024 21:30
@turboFei turboFei self-assigned this Dec 26, 2024
@turboFei turboFei requested a review from pan3793 December 26, 2024 21:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (031caf3) to head (25fb329).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #6870   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         687     688    +1     
  Lines       42515   42545   +30     
  Branches     5799    5800    +1     
======================================
- Misses      42515   42545   +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pan3793
pan3793 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, thanks!

@pan3793 pan3793 added this to the v1.11.0 milestone Dec 27, 2024
@pan3793 pan3793 closed this in 2b37c03 Dec 27, 2024
@pan3793
Copy link
Member

pan3793 commented Dec 27, 2024

Merged to master

@turboFei turboFei deleted the grafana_metrics branch December 27, 2024 02:31
pan3793 added a commit to pan3793/kyuubi that referenced this pull request May 26, 2025
@pan3793
[KYUUBI apache#6870][FOLLOWUP] Correct file name of grafana/README.md
45915d9
pan3793 added a commit that referenced this pull request May 26, 2025
@pan3793
[KYUUBI #6870][FOLLOWUP] Correct file name of grafana/README.md
69ee195 
### Why are the changes needed?

Fix a typo of file name.

### How was this patch tested?

Review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7074 from pan3793/6870-f.

Closes #6870

45915d9 [Cheng Pan] [KYUUBI #6870][FOLLOWUP] Correct file name of grafana/README.md

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
pan3793 added a commit that referenced this pull request May 26, 2025
@pan3793
[KYUUBI #6870][FOLLOWUP] Correct file name of grafana/README.md
6d99b20 
### Why are the changes needed?

Fix a typo of file name.

### How was this patch tested?

Review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #7074 from pan3793/6870-f.

Closes #6870

45915d9 [Cheng Pan] [KYUUBI #6870][FOLLOWUP] Correct file name of grafana/README.md

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pan3793 pan3793 pan3793 approved these changes

@yaooqinn yaooqinn Awaiting requested review from yaooqinn

Assignees

@turboFei turboFei

Labels

None yet

Projects

None yet

Milestone

v1.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@turboFei @pan3793 @codecov-commenter