Skip to content

Allow to use spark-internal as resource for batch job #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turboFei wants to merge 1 commit into from
+7 −3
Closed

Allow to use spark-internal as resource for batch job #3835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ object SparkProcessBuilder {
final val APP_KEY = "spark.app.name"
final val TAG_KEY = "spark.yarn.tags"
final val MASTER_KEY = "spark.master"
final val INTERNAL_RESOURCE = "spark-internal"

@ulysses-you ulysses-you Nov 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we docs the special flag ?


/**
* The path configs from Spark project that might upload local files:
Expand Down
9 changes: 6 additions & 3 deletions kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSessionImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.apache.hive.service.rpc.thrift.TProtocolVersion
import org.apache.kyuubi.client.api.v1.dto.BatchRequest
import org.apache.kyuubi.config.KyuubiConf
import org.apache.kyuubi.engine.KyuubiApplicationManager
import org.apache.kyuubi.engine.spark.SparkProcessBuilder
import org.apache.kyuubi.events.{EventBus, KyuubiSessionEvent}
import org.apache.kyuubi.metrics.MetricsConstants.{CONN_OPEN, CONN_TOTAL}
import org.apache.kyuubi.metrics.MetricsSystem
Expand Down Expand Up @@ -99,9 +100,11 @@ class KyuubiBatchSessionImpl(
batchRequest.getBatchType,
normalizedConf,
sessionManager.getConf)
KyuubiApplicationManager.checkApplicationAccessPath(
batchRequest.getResource,
sessionManager.getConf)
if (batchRequest.getResource != SparkProcessBuilder.INTERNAL_RESOURCE) {
KyuubiApplicationManager.checkApplicationAccessPath(
batchRequest.getResource,
sessionManager.getConf)
}
}

override def open(): Unit = {
Expand Down