Allow to use spark-internal as resource for batch job #3835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Nov 22, 2022
pan3793
changed the title
3 tasks
turboFei
force-pushed
the
spark_internal
branch
from
f128d05 to
552c0e5
Compare
turboFei
added a commit
that referenced
this pull request
Nov 23, 2022
### _Why are the changes needed?_ Allow to use spark-internal as resource for batch job. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate <img width="654" alt="image" src="https://user-images.githubusercontent.com/6757692/203333994-4dee486b-1b3f-4f46-83f9-39fe02f66f0c.png"> - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3835 from turboFei/spark_internal. Closes #3835 552c0e5 [fwang12] allow to use internal resource Authored-by: fwang12 <[email protected]> Signed-off-by: fwang12 <[email protected]> (cherry picked from commit b225a42) Signed-off-by: fwang12 <[email protected]>
Member
Author
|
thanks, merged to master and 1.6.2 |
1 similar comment
Member
Author
|
thanks, merged to master and 1.6.2 |
ulysses-you
reviewed
Nov 23, 2022
| final val APP_KEY = "spark.app.name" | ||
| final val TAG_KEY = "spark.yarn.tags" | ||
| final val MASTER_KEY = "spark.master" | ||
| final val INTERNAL_RESOURCE = "spark-internal" |
Contributor
There was a problem hiding this comment.
shall we docs the special flag ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Allow to use spark-internal as resource for batch job.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate