Skip to content

KAFKA-8147: Add changelog topic configuration to KTable suppress #8965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 4 commits into from
Dec 4, 2020
Merged

KAFKA-8147: Add changelog topic configuration to KTable suppress #8965

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e350b21
KAFKA-8147: Add changelog topic configuration to KTable suppress
Jul 1, 2020
de6e073
update code
Jul 8, 2020
18b303f
updates
Nov 22, 2020
c731d9e
remove example
Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/streams/developer-guide/dsl-api.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3366,7 +3366,7 @@ <h5><a class="toc-backref" href="#id34">KTable-KTable Foreign-Key
grouped
.windowedBy(TimeWindows.of(Duration.ofHours(1)).grace(ofMinutes(10)))
.count()
.suppress(Suppressed.untilWindowCloses(unbounded()))
.suppress(Suppressed.untilWindowCloses(unbounded().withLoggingDisabled()))
.filter((windowedUserId, count) -&gt; count &lt; 3)
.toStream()
.foreach((windowedUserId, count) -&gt; sendAlert(windowedUserId.window(), windowedUserId.key(), count));
Expand All @@ -3393,6 +3393,10 @@ <h5><a class="toc-backref" href="#id34">KTable-KTable Foreign-Key
but this simple example creates a buffer with no
upper bound.
</dd>
<dt><code>withLoggingDisabled()</code></dt>
<dd>
This configures the suppression operator to disable logging for changelog entries.
</dd>

@mjsax mjsax Jul 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to add this in this example? \cc @vvcephei WDYT?

@vvcephei vvcephei Dec 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjsax , I agree; this is an advanced configuration that shouldn't be used most of the time, so I wouldn't put it in the example.

@highluck highluck Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update code thanks!

</dl>
</p>
<p>
Expand Down
5 changes: 5 additions & 0 deletions docs/streams/upgrade-guide.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ <h3><a id="streams_api_changes_260" href="#streams_api_changes_260">Streams API
We added a <code>--force</code> option in StreamsResetter to force remove left-over members on broker side when long session time out was configured
as per <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter">KIP-571</a>.
</p>
<p>
We added a <code>Suppressed.withLoggingDisabled()</code> and <code>Suppressed.withLoggingEnabled(config)</code>
Comment thread
highluck marked this conversation as resolved.
Outdated
method to disables (no s) and allows for configuration of the changelog topic
Comment thread
highluck marked this conversation as resolved.
Outdated
as per <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-446%3A+Add+changelog+topic+configuration+to+KTable+suppress">KIP-446</a>.
</p>

<h3><a id="streams_api_changes_250" href="#streams_api_changes_250">Streams API changes in 2.5.0</a></h3>
<p>
Expand Down