KAFKA-8147: Add changelog topic configuration to KTable suppress#8965
Merged
Conversation
Contributor
Author
|
@mjsax |
mjsax
reviewed
Jul 7, 2020
| <dt><code>withLoggingDisabled()</code></dt> | ||
| <dd> | ||
| This configures the suppression operator to disable logging for changelog entries. | ||
| </dd> |
Member
There was a problem hiding this comment.
Not sure if we want to add this in this example? \cc @vvcephei WDYT?
Contributor
There was a problem hiding this comment.
Thanks @mjsax , I agree; this is an advanced configuration that shouldn't be used most of the time, so I wouldn't put it in the example.
Contributor
Author
There was a problem hiding this comment.
update code thanks!
Contributor
Author
|
@mjsax |
mjsax
reviewed
Nov 17, 2020
mjsax
pushed a commit
that referenced
this pull request
Dec 4, 2020
Reviewer: Matthias J. Sax <matthias@confluent.io>, John Roesler <john@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Dec 4, 2020
Reviewer: Matthias J. Sax <matthias@confluent.io>, John Roesler <john@confluent.io>
Member
|
Merged to |
Member
|
Thanks a lot for the PR @highluck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-8147: Add changelog topic configuration to KTable suppress
Committer Checklist (excluded from commit message)