Skip to content

KAFKA-9706: Handle null keys/values in Flatten transformation #8279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkonstantine merged 3 commits into from
Mar 30, 2020
Merged

KAFKA-9706: Handle null keys/values in Flatten transformation #8279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58d0583
KAFKA-9706: Handle null keys/values in Flatten transformation
gharris1727 Mar 11, 2020
94942a8
Inline misleadingly named isTombstoneRecord function
gharris1727 Mar 25, 2020
a5db3ad
Fix whitespace and indentation
gharris1727 Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Flatten.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,19 @@ public void configure(Map<String, ?> props) {

@Override
public R apply(R record) {
if (operatingSchema(record) == null) {
if (isTombstoneRecord(record)) {
return record;
} else if (operatingSchema(record) == null) {
return applySchemaless(record);
} else {
return applyWithSchema(record);
}
}

private boolean isTombstoneRecord(R record) {
return operatingValue(record) == null;
}

@Override
public void close() {
}
Expand Down
28 changes: 28 additions & 0 deletions connect/transforms/src/test/java/org/apache/kafka/connect/transforms/FlattenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,4 +297,32 @@ public void testOptionalAndDefaultValuesNested() {
Schema transformedOptFieldSchema = SchemaBuilder.string().optional().defaultValue("child_default").build();
assertEquals(transformedOptFieldSchema, transformedSchema.field("opt_field").schema());
}

@Test
public void tombstoneEventWithoutSchemaShouldPassThrough() {
xformValue.configure(Collections.<String, String>emptyMap());

final SourceRecord record = new SourceRecord(null, null, "test", 0,
null, null);
Comment thread
kkonstantine marked this conversation as resolved.
Outdated

Comment thread
gharris1727 marked this conversation as resolved.
Outdated
final SourceRecord transformedRecord = xformValue.apply(record);

assertEquals(null, transformedRecord.value());
assertEquals(null, transformedRecord.valueSchema());
}

@Test
public void tombstoneEventWithSchemaShouldPassThrough() {
xformValue.configure(Collections.<String, String>emptyMap());

final Schema simpleStructSchema = SchemaBuilder.struct().name("name").version(1).doc("doc").field("magic", Schema.OPTIONAL_INT64_SCHEMA).build();

Comment thread
gharris1727 marked this conversation as resolved.
Outdated
final SourceRecord record = new SourceRecord(null, null, "test", 0,
simpleStructSchema, null);

Comment thread
gharris1727 marked this conversation as resolved.
Outdated
final SourceRecord transformedRecord = xformValue.apply(record);

assertEquals(null, transformedRecord.value());
assertEquals(simpleStructSchema, transformedRecord.valueSchema());
}
}