KAFKA-9706: Handle null keys/values in Flatten transformation#8279
Merged
Conversation
* Fix DataException thrown when handling tombstone events with null value * Passes through original record when finding a tombstone record * Add tests for schema and schemaless data Signed-off-by: Greg Harris <gregh@confluent.io>
Contributor
Author
|
This is very similar to #6914 for the InsertField transformation, and uses the same solution and testing strategy. |
Contributor
Author
ncliang
approved these changes
Mar 11, 2020
ncliang
left a comment
ncliang
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks, @gharris1727 !
Contributor
Author
|
cc @kkonstantine @rhauch for review |
Signed-off-by: Greg Harris <gregh@confluent.io>
kkonstantine
approved these changes
Mar 30, 2020
kkonstantine
left a comment
kkonstantine
left a comment
Contributor
There was a problem hiding this comment.
Thanks @gharris1727
Only nits as comments but otherwise, LGTM
Signed-off-by: Greg Harris <gregh@confluent.io>
Contributor
Author
|
@kkonstantine I fixed the whitespace, can you verify that it's correct? |
Contributor
|
ok to test |
Contributor
|
JDK11 green Given the above, I'll move forward with merging this simple bugfix. |
kkonstantine
pushed a commit
that referenced
this pull request
Mar 30, 2020
… is used (#8279) * Fixed DataException thrown when handling tombstone events with null value * Passes through original record when finding a null key when it's configured for keys or a null value when it's configured for values. * Added unit tests for schema and schemaless data
kkonstantine
pushed a commit
that referenced
this pull request
Mar 30, 2020
… is used (#8279) * Fixed DataException thrown when handling tombstone events with null value * Passes through original record when finding a null key when it's configured for keys or a null value when it's configured for values. * Added unit tests for schema and schemaless data
kkonstantine
pushed a commit
that referenced
this pull request
Mar 30, 2020
… is used (#8279) * Fixed DataException thrown when handling tombstone events with null value * Passes through original record when finding a null key when it's configured for keys or a null value when it's configured for values. * Added unit tests for schema and schemaless data
kkonstantine
pushed a commit
that referenced
this pull request
Mar 30, 2020
… is used (#8279) * Fixed DataException thrown when handling tombstone events with null value * Passes through original record when finding a null key when it's configured for keys or a null value when it's configured for values. * Added unit tests for schema and schemaless data
kkonstantine
pushed a commit
that referenced
this pull request
Mar 30, 2020
… is used (#8279) * Fixed DataException thrown when handling tombstone events with null value * Passes through original record when finding a null key when it's configured for keys or a null value when it's configured for values. * Added unit tests for schema and schemaless data
qq619618919
pushed a commit
to qq619618919/kafka
that referenced
this pull request
May 12, 2020
… is used (apache#8279) * Fixed DataException thrown when handling tombstone events with null value * Passes through original record when finding a null key when it's configured for keys or a null value when it's configured for values. * Added unit tests for schema and schemaless data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Harris gregh@confluent.io
Committer Checklist (excluded from commit message)