Skip to content

KAFKA-9490: Fix generics for Grouped #8028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 1 commit into from
Feb 4, 2020
Merged

KAFKA-9490: Fix generics for Grouped #8028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions streams/src/main/java/org/apache/kafka/streams/kstream/Grouped.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.kafka.streams.kstream;


import org.apache.kafka.common.serialization.Serde;

/**
Expand All @@ -35,7 +33,6 @@ public class Grouped<K, V> implements NamedOperation<Grouped<K, V>> {
protected final Serde<V> valueSerde;
protected final String name;


private Grouped(final String name,
final Serde<K> keySerde,
final Serde<V> valueSerde) {
Expand Down Expand Up @@ -71,7 +68,7 @@ public static <K, V> Grouped<K, V> as(final String name) {
* @see KStream#groupBy(KeyValueMapper, Grouped)
* @see KTable#groupBy(KeyValueMapper, Grouped)
*/
public static <K> Grouped keySerde(final Serde<K> keySerde) {
public static <K, V> Grouped<K, V> keySerde(final Serde<K> keySerde) {
return new Grouped<>(null, keySerde, null);
}

Expand All @@ -85,7 +82,7 @@ public static <K> Grouped keySerde(final Serde<K> keySerde) {
* @see KStream#groupBy(KeyValueMapper, Grouped)
* @see KTable#groupBy(KeyValueMapper, Grouped)
*/
public static <V> Grouped valueSerde(final Serde<V> valueSerde) {
public static <K, V> Grouped<K, V> valueSerde(final Serde<V> valueSerde) {
return new Grouped<>(null, null, valueSerde);
}

Expand Down